Uh oh!
There was an error while loading. Please reload this page.
feat: after simulate and before sign hooks - #5503
Merged
Merged
Conversation
matthewwalsh0
commented
Mar 19, 2025
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
commented
Mar 19, 2025
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0force-pushed
the
feat/after-simulate-hook
branch
2 times, most recently
from
June 2, 2025 15:46
1850f31 to
8c03250Comparematthewwalsh0force-pushed
the
feat/after-simulate-hook
branch
from
June 9, 2025 10:25
59d5e09 to
4d46a3eComparematthewwalsh0
marked this pull request as ready for review
June 9, 2025 10:25
matthewwalsh0
commented
Jun 9, 2025
MemberAuthor
@metamaskbot publish-preview |
1 similar comment
matthewwalsh0
commented
Jun 10, 2025
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
previously approved these changes
Jun 11, 2025
pedronfigueiredo
previously approved these changes
Jun 11, 2025
Support disabled signature checks in DelegationManager. Add estimateGas action. Remove automatic gas update.
matthewwalsh0
dismissed stale reviews from pedronfigueiredo and OGPoyraz
via
June 12, 2025 08:37
5dcf9a1matthewwalsh0force-pushed
the
feat/after-simulate-hook
branch
from
June 12, 2025 08:37
4d46a3e to
5dcf9a1Comparematthewwalsh0
enabled auto-merge (squash)
June 12, 2025 08:37
OGPoyraz
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Support
afterSimulateandbeforeSignhooks, including optionalupdateTransactioncallbacks.The
afterSimulatehook can also returnskipSimulationwhich will disable subsequent balance change simulation.Plus:
containerTypesproperty toTransactionMeta.TransactionControllerEstimateGasActionmessenger action.ignoreDelegationSignaturesoption toestimateGasmethod.DelegationManagersignature errors in simulation requests.References
Fixes#5170
Checklist