feat: add `MegaEth Testnet` as default network by wantedsystem · Pull Request #5506 · MetaMask/core

wantedsystem · 2025-03-19T18:26:20Z

Explanation

Further to Previous PR: #5495

We are adding MegaETH Testnet as default network on Network Controller default state - networkConfigurationsByChainId with the constants and type from the latest controller-utils

Which enable adding MegaETH Testnet as a default network on Mobile / Extension

Changes:

Refactor the logic to separate the construction of default network configurations to methodsgetDefaultInfuraNetworkConfigurationsByChainId and getDefaultCustomNetworkConfigurationsByChainId
Fix mock-network not support a use case when the RPC endpoint come with a path segment, e.g: 'https://carrot.megaeth.com/rpc'
Add MegaETH Testnet ChainId into constants CHAIN_IDS from transaction-controller

Note :

For everyone interested in testing this version in MM mobile you can use this branch to do so : https://github.com/MetaMask/metamask-mobile/tree/feat/add-megaeth-testnet

References

Changelog

`@metamask/network-controller`

ADDED: Add MegaETH Testnet as default network

`@metamask/transaction-controller`

ADDED: Add MegaETH Testnet ChainId into constants CHAIN_IDS

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate
I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

stanleyyconsensys · 2025-03-20T09:02:50Z

@metamaskbot publish-preview

that one is for 22.2

github-actions · 2025-03-20T09:08:02Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
"@metamask-previews/accounts-controller": "26.1.0-preview-86cafc23",
"@metamask-previews/address-book-controller": "6.0.3-preview-86cafc23",
"@metamask-previews/announcement-controller": "7.0.3-preview-86cafc23",
"@metamask-previews/approval-controller": "7.1.3-preview-86cafc23",
"@metamask-previews/assets-controllers": "54.0.0-preview-86cafc23",
"@metamask-previews/base-controller": "8.0.0-preview-86cafc23",
"@metamask-previews/bridge-controller": "8.0.0-preview-86cafc23",
"@metamask-previews/bridge-status-controller": "8.0.0-preview-86cafc23",
"@metamask-previews/build-utils": "3.0.3-preview-86cafc23",
"@metamask-previews/chain-agnostic-permission": "0.1.0-preview-86cafc23",
"@metamask-previews/composable-controller": "11.0.0-preview-86cafc23",
"@metamask-previews/controller-utils": "11.6.0-preview-86cafc23",
"@metamask-previews/earn-controller": "0.8.0-preview-86cafc23",
"@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-86cafc23",
"@metamask-previews/ens-controller": "15.0.2-preview-86cafc23",
"@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-86cafc23",
"@metamask-previews/gas-fee-controller": "22.0.3-preview-86cafc23",
"@metamask-previews/json-rpc-engine": "10.0.3-preview-86cafc23",
"@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-86cafc23",
"@metamask-previews/keyring-controller": "21.0.0-preview-86cafc23",
"@metamask-previews/logging-controller": "6.0.4-preview-86cafc23",
"@metamask-previews/message-manager": "12.0.1-preview-86cafc23",
"@metamask-previews/multichain": "4.0.0-preview-86cafc23",
"@metamask-previews/multichain-api-middleware": "0.1.0-preview-86cafc23",
"@metamask-previews/multichain-network-controller": "0.2.0-preview-86cafc23",
"@metamask-previews/multichain-transactions-controller": "0.7.2-preview-86cafc23",
"@metamask-previews/name-controller": "8.0.3-preview-86cafc23",
"@metamask-previews/network-controller": "22.2.1-preview-86cafc23",
"@metamask-previews/notification-services-controller": "4.0.0-preview-86cafc23",
"@metamask-previews/permission-controller": "11.0.6-preview-86cafc23",
"@metamask-previews/permission-log-controller": "3.0.3-preview-86cafc23",
"@metamask-previews/phishing-controller": "12.4.1-preview-86cafc23",
"@metamask-previews/polling-controller": "12.0.3-preview-86cafc23",
"@metamask-previews/preferences-controller": "17.0.0-preview-86cafc23",
"@metamask-previews/profile-sync-controller": "10.1.0-preview-86cafc23",
"@metamask-previews/queued-request-controller": "9.0.1-preview-86cafc23",
"@metamask-previews/rate-limit-controller": "6.0.3-preview-86cafc23",
"@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-86cafc23",
"@metamask-previews/sample-controllers": "0.0.0-preview-86cafc23",
"@metamask-previews/selected-network-controller": "21.0.1-preview-86cafc23",
"@metamask-previews/signature-controller": "26.0.0-preview-86cafc23",
"@metamask-previews/token-search-discovery-controller": "2.1.0-preview-86cafc23",
"@metamask-previews/transaction-controller": "50.0.0-preview-86cafc23",
"@metamask-previews/user-operation-controller": "29.0.0-preview-86cafc23"
}

mcmire

Nice, good job! I just had two questions but they are non-blocking.

stanleyyconsensys · 2025-03-21T08:32:09Z

@metamaskbot publish-preview

that one is based on 23

github-actions · 2025-03-21T08:37:09Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
"@metamask-previews/accounts-controller": "27.0.0-preview-a47985c",
"@metamask-previews/address-book-controller": "6.0.3-preview-a47985c",
"@metamask-previews/announcement-controller": "7.0.3-preview-a47985c",
"@metamask-previews/approval-controller": "7.1.3-preview-a47985c",
"@metamask-previews/assets-controllers": "55.0.1-preview-a47985c",
"@metamask-previews/base-controller": "8.0.0-preview-a47985c",
"@metamask-previews/bridge-controller": "9.0.0-preview-a47985c",
"@metamask-previews/bridge-status-controller": "9.0.0-preview-a47985c",
"@metamask-previews/build-utils": "3.0.3-preview-a47985c",
"@metamask-previews/chain-agnostic-permission": "0.1.0-preview-a47985c",
"@metamask-previews/composable-controller": "11.0.0-preview-a47985c",
"@metamask-previews/controller-utils": "11.6.0-preview-a47985c",
"@metamask-previews/earn-controller": "0.9.0-preview-a47985c",
"@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-a47985c",
"@metamask-previews/ens-controller": "16.0.0-preview-a47985c",
"@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-a47985c",
"@metamask-previews/gas-fee-controller": "23.0.0-preview-a47985c",
"@metamask-previews/json-rpc-engine": "10.0.3-preview-a47985c",
"@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-a47985c",
"@metamask-previews/keyring-controller": "21.0.0-preview-a47985c",
"@metamask-previews/logging-controller": "6.0.4-preview-a47985c",
"@metamask-previews/message-manager": "12.0.1-preview-a47985c",
"@metamask-previews/multichain": "4.0.0-preview-a47985c",
"@metamask-previews/multichain-api-middleware": "0.1.0-preview-a47985c",
"@metamask-previews/multichain-network-controller": "0.3.0-preview-a47985c",
"@metamask-previews/multichain-transactions-controller": "0.8.0-preview-a47985c",
"@metamask-previews/name-controller": "8.0.3-preview-a47985c",
"@metamask-previews/network-controller": "23.0.0-preview-a47985c",
"@metamask-previews/notification-services-controller": "5.0.0-preview-a47985c",
"@metamask-previews/permission-controller": "11.0.6-preview-a47985c",
"@metamask-previews/permission-log-controller": "3.0.3-preview-a47985c",
"@metamask-previews/phishing-controller": "12.4.1-preview-a47985c",
"@metamask-previews/polling-controller": "13.0.0-preview-a47985c",
"@metamask-previews/preferences-controller": "17.0.0-preview-a47985c",
"@metamask-previews/profile-sync-controller": "11.0.0-preview-a47985c",
"@metamask-previews/queued-request-controller": "10.0.0-preview-a47985c",
"@metamask-previews/rate-limit-controller": "6.0.3-preview-a47985c",
"@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-a47985c",
"@metamask-previews/sample-controllers": "0.0.0-preview-a47985c",
"@metamask-previews/selected-network-controller": "22.0.0-preview-a47985c",
"@metamask-previews/signature-controller": "27.0.0-preview-a47985c",
"@metamask-previews/token-search-discovery-controller": "2.1.0-preview-a47985c",
"@metamask-previews/transaction-controller": "51.0.0-preview-a47985c",
"@metamask-previews/user-operation-controller": "30.0.0-preview-a47985c"
}

mcmire

Looks good to me! Just need another review from the Confirmations team.

- fix mock network hardcoded mock path when RPC has endpoint with '/rpc' - fix test result on token detection when megaETH network added as default

This reverts commit e323f71.

Reverts #5506

stanleyyconsensys changed the title ~~feat: add megaEth testnet to network controller~~feat: add MegaEth Testnet to network controllerMar 20, 2025

stanleyyconsensys changed the title ~~feat: add MegaEth Testnet to network controller~~feat: add MegaEth Testnet to network-controllerMar 20, 2025

wantedsystem marked this pull request as ready for review March 20, 2025 09:01

wantedsystem requested review from a team as code owners March 20, 2025 09:01

mcmire previously approved these changes Mar 20, 2025
View reviewed changes

Comment threadpackages/network-controller/tests/NetworkController.test.ts Outdated
Comment threadtests/mock-network.ts Outdated

stanleyyconsensys dismissed mcmire’s stale review via fd5ef93March 20, 2025 14:24

mcmire previously approved these changes Mar 20, 2025
View reviewed changes

stanleyyconsensys force-pushed the feat/add-megaeth-testnet-to-network-controller branch from fd5ef93 to a47985cCompare March 21, 2025 08:13

stanleyyconsensys dismissed mcmire’s stale review via 2fd5d05March 21, 2025 10:00

stanleyyconsensys requested a review from a team as a code owner March 21, 2025 10:00

stanleyyconsensys changed the title ~~feat: add MegaEth Testnet to network-controller~~feat: add MegaEth Testnet as default networkMar 21, 2025

Prithpal-Sooriya approved these changes Mar 21, 2025
View reviewed changes

wantedsystem requested a review from mcmire March 21, 2025 12:09

mcmire approved these changes Mar 21, 2025
View reviewed changes

mcmire mentioned this pull request Mar 21, 2025
Release 338.0.0 #5518
Merged

matthewwalsh0 approved these changes Mar 21, 2025
View reviewed changes

stanleyyconsensys enabled auto-merge (squash) March 21, 2025 14:01

wantedsystemand others added 7 commits March 21, 2025 22:02

feat: add megaEth testnet to network controller
443eb96

chore: update network controller
0e9bb81

fix: mock network
53f9f98
- fix mock network hardcoded mock path when RPC has endpoint with '/rpc' - fix test result on token detection when megaETH network added as default

fix: lint
892d4a1

chore: lint
0a530c7

chore: use explicit rpc for megaEth test case
c06169f

chore: add MegaEth testnet into transaction controller
c49760a

stanleyyconsensys force-pushed the feat/add-megaeth-testnet-to-network-controller branch from 2fd5d05 to c49760aCompare March 21, 2025 14:02

stanleyyconsensys merged commit e323f71 into mainMar 21, 2025

stanleyyconsensys deleted the feat/add-megaeth-testnet-to-network-controller branch March 21, 2025 14:07

stanleyyconsensys added the team-network-enablement label Mar 21, 2025

stanleyyconsensys restored the feat/add-megaeth-testnet-to-network-controller branch March 21, 2025 14:45

wantedsystem added a commit that referenced this pull request Mar 21, 2025
Revert "feat: addMegaEth Testnetas default network (#5506)"
d9c61a2
This reverts commit e323f71.

wantedsystem mentioned this pull request Mar 21, 2025
Revert "feat: add MegaEth Testnet as default network" #5520
Merged

wantedsystem added a commit that referenced this pull request Mar 21, 2025
Revert "feat: addMegaEth Testnetas default network" (#5520)
f66b372
Reverts #5506

Navigation Menu

Uh oh!

Uh oh!

feat: add `MegaEth Testnet` as default network - #5506

feat: add `MegaEth Testnet` as default network#5506
stanleyyconsensys merged 7 commits into
mainfrom
feat/add-megaeth-testnet-to-network-controller

wantedsystem commented Mar 19, 2025•
edited
Loading

Uh oh!

stanleyyconsensys commented Mar 20, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Mar 20, 2025

Uh oh!

mcmire left a comment

Uh oh!

Uh oh!

Uh oh!

stanleyyconsensys commented Mar 21, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Mar 21, 2025

Uh oh!

mcmire left a comment •
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

wantedsystem commented Mar 19, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

Changes:

Note :

References

Changelog

@metamask/network-controller

@metamask/transaction-controller

Checklist

Uh oh!

stanleyyconsensys commented Mar 20, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Mar 20, 2025

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stanleyyconsensys commented Mar 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Mar 21, 2025

Uh oh!

mcmire left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wantedsystem commented Mar 19, 2025•
edited
Loading

`@metamask/network-controller`

`@metamask/transaction-controller`

stanleyyconsensys commented Mar 20, 2025•
edited
Loading

stanleyyconsensys commented Mar 21, 2025•
edited
Loading

mcmire left a comment •
edited
Loading