Uh oh!
There was an error while loading. Please reload this page.
feat: add gas fee tokens to transaction metadata - #5524
Merged
Conversation
matthewwalsh0
commented
Mar 21, 2025
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0force-pushed
the
feat/gas-fee-tokens
branch
from
March 24, 2025 21:13
e56c504 to
2c325b5Comparematthewwalsh0
marked this pull request as ready for review
March 24, 2025 21:15
matthewwalsh0
commented
Mar 24, 2025
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0force-pushed
the
feat/publish-batch-hook
branch
from
March 25, 2025 10:52
7ee3ac2 to
f723ee3Comparematthewwalsh0force-pushed
the
feat/gas-fee-tokens
branch
from
March 25, 2025 12:35
ac78b26 to
02959a3CompareUh oh!
There was an error while loading. Please reload this page.
pedronfigueiredo
approved these changes
Mar 25, 2025
OGPoyraz
approved these changes
Mar 25, 2025
matthewwalsh0
enabled auto-merge (squash)
March 25, 2025 16:12
Add types. Fix unit tests.
Remove gas fee from simulation request.
matthewwalsh0force-pushed
the
feat/gas-fee-tokens
branch
from
March 25, 2025 16:12
57265c8 to
2ffc20fCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Retrieve the available gas fee tokens from the simulation API when adding a transaction, and save them in the transaction metadata.
Specifically:
gasFeeTokenstoTransactionMetadata.selectedGasFeeTokentoTransactionMetadata.utils/simulation-api.ts.utils/simulation.tsto parse the gas fee tokens from the response.References
Fixes#4458
Changelog
See
CHANGELOG.md.Checklist