Uh oh!
There was an error while loading. Please reload this page.
Move controller messenger type demonstration to its own test suite - #565
Merged
Conversation
Merged
amitabh94 pushed a commit
to amitabh94/core
that referenced
this pull request
Jun 16, 2026
* 22.4.0 * chore(release/22.4.0): update changelog --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: rarquevaux <r.arquevaux@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we demonstrated how controller messenger generics could be a union of actions and events from different controllers in the currency rate controller tests. Although we have use cases in production that demonstrate this, I think it's worthwhile to keep an example in the tests. This PR moves this type demonstration into the controller messenger test suite.