Skip to content

[FEATURE] Manage transaction state - #582

Merged
gantunesr merged 42 commits into
mainfrom
feat/tx-state
Sep 9, 2021
Merged

[FEATURE] Manage transaction state#582
gantunesr merged 42 commits into
mainfrom
feat/tx-state

Conversation

@gantunesr

@gantunesrgantunesr commented Sep 7, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Description

This development only affects the mobile app since the extension has its own Transaction Controller

Improvement on how we process transaction state by updating the Transaction Controller. The extension currently has a Transaction State Controller to handle user scenarios, something we lack.

Use Cases

  • On transaction history we're currently using the gas values that the user sent the transaction with, but in many cases the actual gas spent was less so we are showing misleading information.
  • Wrong transaction state: Showing failed transaction, when the tx was successful.
  • Wrong transaction state: “Dropped and replaced” shows up in etherscan and our end shows pending
  • The states of transactions 2 transactions with same nonce are shown wrongly.
  • Transactions get stuck in the "Submitted" status.

gantunesr added 29 commits September 1, 2021 12:14
gantunesr
feat(TxState): Add logs to debug
23de831
gantunesr
feat(TxController): Add StateReconcileMethod enum
b26d881
gantunesr
feat(TxController): Add method to get outdated txs
de7f56a
gantunesr
feat(TxController): Add method to get array of outdated txs
23f6096
gantunesr
feat(TxController): Add method to get array of new txs
3e5818c
gantunesr
feat(TxController): Add method to reconcile txs from etherscan
376a972
gantunesr
feat(TxController): Add method to reconcile txs
2e3199c
gantunesr
feat(TxController): Add reconcile method to etherscan fetch
0af90be
gantunesr
test(TransactionController): Unify mocks in a single file
b9e7992
gantunesr
Update brach to main
ef99cff
gantunesr
feat(getEtherscanApiUrl): Modify method to construct any url
3bc9203
gantunesr
test(getEtherscanApiUrl): Update
2f53370
gantunesr
feat(TransactionController): Add EtherscanTransactionStatus
93e0561
gantunesr
feat(TransactionController): Add new status for TransactionStatus
fff6ddc
gantunesr
feat(TransactionController): Add new failed condition for blockchain …
94508a2
…queries
gantunesr
feat(TransactionController): Get transaction from state
42c74c9
gantunesr
feat(TransactionController): Update transactionStateReconciler method
389a027
gantunesr
feat(TransactionController): Update etherscanTransactionStateReconcil…
d70848e
…er method
gantunesr
feat(TransactionController): Update getOutdatedTransactions method
cc5848e
gantunesr
feat(TransactionController): Add isTransactionOutdated method
7323630
gantunesr
feat(TransactionController): Update isStatusOutdated method
3c054c9
gantunesr
feat(TransactionController): Add isGasDataOutdated method
053e9ec
gantunesr
feat(TransactionController): Update trimTransactionsForState method
146f26a
gantunesr
feat(TransactionController): Relocate isFinalState method
f00d46f
gantunesr
feat(handletransationStatusFetch): Add method to check tx status in e…
eeea0f2
…therscan
gantunesr
feat(handleTransactionFetch): Update method
9b8e3ef
gantunesr
style(util): Indentation
5b9a7aa
gantunesr
test(TransactionController): Update
31b19ce
gantunesr
Merge branch 'main' ofhttps://github.com/MetaMask/controllersinto f…
35c46e7
…eat/tx-state
gantunesr
gantunesr commented Sep 7, 2021
View reviewed changes
Comment threadsrc/transaction/TransactionController.test.ts Outdated
@gantunesr
gantunesr requested review from a team and brad-decker and removed request for a teamSeptember 8, 2021 20:24
sethkfman
sethkfman previously approved these changes Sep 8, 2021
View reviewed changes

@sethkfmansethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adonesky1
adonesky1 reviewed Sep 8, 2021
View reviewed changes

@adonesky1adonesky1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions! Nothing major though.

Comment threadsrc/transaction/TransactionController.ts Outdated
Comment threadsrc/transaction/TransactionController.ts
Comment threadsrc/transaction/TransactionController.ts Outdated
Comment threadsrc/transaction/TransactionController.ts Outdated
Comment threadsrc/util.ts Outdated
Gudahtt
Gudahtt reviewed Sep 8, 2021
View reviewed changes
Comment threadsrc/transaction/TransactionController.ts Outdated
Gudahtt
Gudahtt reviewed Sep 8, 2021
View reviewed changes
Comment threadsrc/transaction/TransactionController.ts
Gudahtt
Gudahtt reviewed Sep 8, 2021
View reviewed changes
Comment threadsrc/transaction/TransactionController.ts Outdated
adonesky1
adonesky1 reviewed Sep 9, 2021
View reviewed changes
Comment threadsrc/transaction/TransactionController.ts Outdated
adonesky1
adonesky1 reviewed Sep 9, 2021
View reviewed changes
Comment threadsrc/transaction/TransactionController.ts Outdated
adonesky1
adonesky1 reviewed Sep 9, 2021
View reviewed changes
Comment threadsrc/transaction/TransactionController.ts Outdated
adonesky1
adonesky1 previously approved these changes Sep 9, 2021
View reviewed changes

@adonesky1adonesky1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment non-blocking nits. LGTM!

@gantunesr
gantunesr merged commit 3f5ca30 into mainSep 9, 2021
@gantunesr
gantunesr deleted the feat/tx-state branch September 9, 2021 15:03
amitabh94 pushed a commit to amitabh94/core that referenced this pull request Jun 16, 2026
@github-actions@rarquevaux
24.0.0 (MetaMask#582)
5add822
* 24.0.0
* chore(release): updated CHANGELOG for 24.0.0
---------
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: rarquevaux <r.arquevaux@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adonesky1adonesky1adonesky1 approved these changes
@brad-deckerbrad-deckerAwaiting requested review from brad-decker
@GudahttGudahttAwaiting requested review from Gudahtt
@sethkfmansethkfmanAwaiting requested review from sethkfman

Assignees

@gantunesrgantunesr

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gantunesr@Gudahtt@sethkfman@adonesky1