Skip to content

feat: add lending functionality to controller - #5828

Merged
nickewansmith merged 12 commits into
mainfrom
STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller
Jun 2, 2025
Merged

feat: add lending functionality to controller#5828
nickewansmith merged 12 commits into
mainfrom
STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller

Conversation

@nickewansmith

@nickewansmithnickewansmith commented May 19, 2025

Copy link
Copy Markdown
Contributor

Explanation

  • What is the current state of things and why does it need to change?
  • Currently we do not have lending functionality in the earn controller. We want to be able to control pooled staking and lending from one source such that we can extend to extension easily
  • What is the solution your changes offer and how does it work?
  • updates earn sdk to latest
  • adds lending api methods and helpers
  • adds lending contract methods and helpers
  • adds multichain for pooled staking state
  • Are there any changes whose purpose might not obvious to those unfamiliar with the domain?
  • No I don't think so
  • If your primary goal was to update one package but you found you had to update another one along the way, why did you do so?
    • n/a
  • If you had to upgrade a dependency, why did you do so?
  • We need the latest stake-sdk to use lending functionality

References

Fixes https://consensyssoftware.atlassian.net/browse/STAKE-904

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch 3 times, most recently from e98615a to cf6f81fCompareMay 19, 2025 22:18
@socket-security

socket-securityBot commented May 19, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

DiffPackageSupply Chain
Security
VulnerabilityQualityMaintenanceLicense
Updated@​metamask/​stake-sdk@​1.0.0 ⏵ 3.2.089+110094+198100

View full report

@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch 2 times, most recently from dd2a4d6 to 6a84ad7CompareMay 19, 2025 22:49
@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@metamaskbot publish-preview

@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch from 6a84ad7 to 37f78daCompareMay 20, 2025 00:36
@nickewansmith
nickewansmith marked this pull request as ready for review May 20, 2025 00:41
@nickewansmith
nickewansmith requested review from a team as code ownersMay 20, 2025 00:41
@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@metamaskbot publish-preview

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
"@metamask-previews/accounts-controller": "29.0.0-preview-37f78da",
"@metamask-previews/address-book-controller": "6.0.3-preview-37f78da",
"@metamask-previews/announcement-controller": "7.0.3-preview-37f78da",
"@metamask-previews/app-metadata-controller": "1.0.0-preview-37f78da",
"@metamask-previews/approval-controller": "7.1.3-preview-37f78da",
"@metamask-previews/assets-controllers": "63.0.0-preview-37f78da",
"@metamask-previews/base-controller": "8.0.1-preview-37f78da",
"@metamask-previews/bridge-controller": "25.1.0-preview-37f78da",
"@metamask-previews/bridge-status-controller": "21.0.0-preview-37f78da",
"@metamask-previews/build-utils": "3.0.3-preview-37f78da",
"@metamask-previews/chain-agnostic-permission": "0.7.0-preview-37f78da",
"@metamask-previews/composable-controller": "11.0.0-preview-37f78da",
"@metamask-previews/controller-utils": "11.9.0-preview-37f78da",
"@metamask-previews/delegation-controller": "0.3.0-preview-37f78da",
"@metamask-previews/earn-controller": "0.14.0-preview-37f78da",
"@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-37f78da",
"@metamask-previews/ens-controller": "16.0.0-preview-37f78da",
"@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-37f78da",
"@metamask-previews/gas-fee-controller": "23.0.0-preview-37f78da",
"@metamask-previews/json-rpc-engine": "10.0.3-preview-37f78da",
"@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-37f78da",
"@metamask-previews/keyring-controller": "22.0.0-preview-37f78da",
"@metamask-previews/logging-controller": "6.0.4-preview-37f78da",
"@metamask-previews/message-manager": "12.0.1-preview-37f78da",
"@metamask-previews/multichain": "4.1.0-preview-37f78da",
"@metamask-previews/multichain-api-middleware": "0.3.0-preview-37f78da",
"@metamask-previews/multichain-network-controller": "0.7.0-preview-37f78da",
"@metamask-previews/multichain-transactions-controller": "1.0.0-preview-37f78da",
"@metamask-previews/name-controller": "8.0.3-preview-37f78da",
"@metamask-previews/network-controller": "23.5.0-preview-37f78da",
"@metamask-previews/notification-services-controller": "8.0.0-preview-37f78da",
"@metamask-previews/permission-controller": "11.0.6-preview-37f78da",
"@metamask-previews/permission-log-controller": "3.0.3-preview-37f78da",
"@metamask-previews/phishing-controller": "12.5.0-preview-37f78da",
"@metamask-previews/polling-controller": "13.0.0-preview-37f78da",
"@metamask-previews/preferences-controller": "18.0.0-preview-37f78da",
"@metamask-previews/profile-sync-controller": "15.0.0-preview-37f78da",
"@metamask-previews/queued-request-controller": "10.0.0-preview-37f78da",
"@metamask-previews/rate-limit-controller": "6.0.3-preview-37f78da",
"@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-37f78da",
"@metamask-previews/sample-controllers": "0.1.0-preview-37f78da",
"@metamask-previews/selected-network-controller": "22.1.0-preview-37f78da",
"@metamask-previews/signature-controller": "29.0.0-preview-37f78da",
"@metamask-previews/token-search-discovery-controller": "3.1.0-preview-37f78da",
"@metamask-previews/transaction-controller": "56.1.0-preview-37f78da",
"@metamask-previews/user-operation-controller": "35.0.0-preview-37f78da"
}

@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@metamaskbot publish-preview

@nickewansmith
nickewansmith marked this pull request as draft May 21, 2025 11:16
@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
"@metamask-previews/accounts-controller": "29.0.0-preview-7bb49dcb",
"@metamask-previews/address-book-controller": "6.0.3-preview-7bb49dcb",
"@metamask-previews/announcement-controller": "7.0.3-preview-7bb49dcb",
"@metamask-previews/app-metadata-controller": "1.0.0-preview-7bb49dcb",
"@metamask-previews/approval-controller": "7.1.3-preview-7bb49dcb",
"@metamask-previews/assets-controllers": "63.0.0-preview-7bb49dcb",
"@metamask-previews/base-controller": "8.0.1-preview-7bb49dcb",
"@metamask-previews/bridge-controller": "25.1.0-preview-7bb49dcb",
"@metamask-previews/bridge-status-controller": "22.0.0-preview-7bb49dcb",
"@metamask-previews/build-utils": "3.0.3-preview-7bb49dcb",
"@metamask-previews/chain-agnostic-permission": "0.7.0-preview-7bb49dcb",
"@metamask-previews/composable-controller": "11.0.0-preview-7bb49dcb",
"@metamask-previews/controller-utils": "11.9.0-preview-7bb49dcb",
"@metamask-previews/delegation-controller": "0.3.0-preview-7bb49dcb",
"@metamask-previews/earn-controller": "0.14.0-preview-7bb49dcb",
"@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-7bb49dcb",
"@metamask-previews/ens-controller": "16.0.0-preview-7bb49dcb",
"@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-7bb49dcb",
"@metamask-previews/gas-fee-controller": "23.0.0-preview-7bb49dcb",
"@metamask-previews/json-rpc-engine": "10.0.3-preview-7bb49dcb",
"@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-7bb49dcb",
"@metamask-previews/keyring-controller": "22.0.0-preview-7bb49dcb",
"@metamask-previews/logging-controller": "6.0.4-preview-7bb49dcb",
"@metamask-previews/message-manager": "12.0.1-preview-7bb49dcb",
"@metamask-previews/multichain": "4.1.0-preview-7bb49dcb",
"@metamask-previews/multichain-api-middleware": "0.3.0-preview-7bb49dcb",
"@metamask-previews/multichain-network-controller": "0.7.0-preview-7bb49dcb",
"@metamask-previews/multichain-transactions-controller": "1.0.0-preview-7bb49dcb",
"@metamask-previews/name-controller": "8.0.3-preview-7bb49dcb",
"@metamask-previews/network-controller": "23.5.0-preview-7bb49dcb",
"@metamask-previews/notification-services-controller": "8.0.0-preview-7bb49dcb",
"@metamask-previews/permission-controller": "11.0.6-preview-7bb49dcb",
"@metamask-previews/permission-log-controller": "3.0.3-preview-7bb49dcb",
"@metamask-previews/phishing-controller": "12.5.0-preview-7bb49dcb",
"@metamask-previews/polling-controller": "13.0.0-preview-7bb49dcb",
"@metamask-previews/preferences-controller": "18.0.0-preview-7bb49dcb",
"@metamask-previews/profile-sync-controller": "15.0.0-preview-7bb49dcb",
"@metamask-previews/queued-request-controller": "10.0.0-preview-7bb49dcb",
"@metamask-previews/rate-limit-controller": "6.0.3-preview-7bb49dcb",
"@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-7bb49dcb",
"@metamask-previews/sample-controllers": "0.1.0-preview-7bb49dcb",
"@metamask-previews/selected-network-controller": "22.1.0-preview-7bb49dcb",
"@metamask-previews/signature-controller": "29.0.0-preview-7bb49dcb",
"@metamask-previews/token-search-discovery-controller": "3.1.0-preview-7bb49dcb",
"@metamask-previews/transaction-controller": "56.1.0-preview-7bb49dcb",
"@metamask-previews/user-operation-controller": "35.0.0-preview-7bb49dcb"
}

@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch 4 times, most recently from e4411aa to 8fef31fCompareMay 28, 2025 21:36
@nickewansmith
nickewansmith marked this pull request as ready for review May 28, 2025 21:36
@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@metamaskbot publish-preview

1 similar comment
@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@metamaskbot publish-preview

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions for the changelog. It would be good to roll back the version bump and also get more context around exporting @metamask/stake-sdk.

Comment threadpackages/earn-controller/package.json Outdated
Comment threadpackages/earn-controller/CHANGELOG.md Outdated
Comment threadpackages/earn-controller/src/selectors.ts Outdated
Comment threadpackages/earn-controller/src/index.ts Outdated
Comment threadpackages/earn-controller/src/index.ts Outdated
@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review and pointers @mcmire I will take a look soon and adjust.

@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch from d2b9c33 to 4ef4efdCompareMay 29, 2025 23:11
@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@metamaskbot publish-preview

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
"@metamask-previews/accounts-controller": "29.0.0-preview-4ef4efd7",
"@metamask-previews/address-book-controller": "6.0.3-preview-4ef4efd7",
"@metamask-previews/announcement-controller": "7.0.3-preview-4ef4efd7",
"@metamask-previews/app-metadata-controller": "1.0.0-preview-4ef4efd7",
"@metamask-previews/approval-controller": "7.1.3-preview-4ef4efd7",
"@metamask-previews/assets-controllers": "66.0.0-preview-4ef4efd7",
"@metamask-previews/base-controller": "8.0.1-preview-4ef4efd7",
"@metamask-previews/bridge-controller": "29.0.0-preview-4ef4efd7",
"@metamask-previews/bridge-status-controller": "26.0.0-preview-4ef4efd7",
"@metamask-previews/build-utils": "3.0.3-preview-4ef4efd7",
"@metamask-previews/chain-agnostic-permission": "0.7.0-preview-4ef4efd7",
"@metamask-previews/composable-controller": "11.0.0-preview-4ef4efd7",
"@metamask-previews/controller-utils": "11.9.0-preview-4ef4efd7",
"@metamask-previews/delegation-controller": "0.3.0-preview-4ef4efd7",
"@metamask-previews/earn-controller": "0.14.0-preview-4ef4efd7",
"@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-4ef4efd7",
"@metamask-previews/ens-controller": "16.0.0-preview-4ef4efd7",
"@metamask-previews/error-reporting-service": "1.0.0-preview-4ef4efd7",
"@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-4ef4efd7",
"@metamask-previews/gas-fee-controller": "23.0.0-preview-4ef4efd7",
"@metamask-previews/json-rpc-engine": "10.0.3-preview-4ef4efd7",
"@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-4ef4efd7",
"@metamask-previews/keyring-controller": "22.0.0-preview-4ef4efd7",
"@metamask-previews/logging-controller": "6.0.4-preview-4ef4efd7",
"@metamask-previews/message-manager": "12.0.1-preview-4ef4efd7",
"@metamask-previews/multichain": "4.1.0-preview-4ef4efd7",
"@metamask-previews/multichain-api-middleware": "0.4.0-preview-4ef4efd7",
"@metamask-previews/multichain-network-controller": "0.7.0-preview-4ef4efd7",
"@metamask-previews/multichain-transactions-controller": "1.0.0-preview-4ef4efd7",
"@metamask-previews/name-controller": "8.0.3-preview-4ef4efd7",
"@metamask-previews/network-controller": "23.5.1-preview-4ef4efd7",
"@metamask-previews/notification-services-controller": "8.0.0-preview-4ef4efd7",
"@metamask-previews/permission-controller": "11.0.6-preview-4ef4efd7",
"@metamask-previews/permission-log-controller": "3.0.3-preview-4ef4efd7",
"@metamask-previews/phishing-controller": "12.5.0-preview-4ef4efd7",
"@metamask-previews/polling-controller": "13.0.0-preview-4ef4efd7",
"@metamask-previews/preferences-controller": "18.1.0-preview-4ef4efd7",
"@metamask-previews/profile-sync-controller": "15.0.0-preview-4ef4efd7",
"@metamask-previews/queued-request-controller": "10.0.0-preview-4ef4efd7",
"@metamask-previews/rate-limit-controller": "6.0.3-preview-4ef4efd7",
"@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-4ef4efd7",
"@metamask-previews/sample-controllers": "0.1.0-preview-4ef4efd7",
"@metamask-previews/seedless-onboarding-controller": "0.0.0-preview-4ef4efd7",
"@metamask-previews/selected-network-controller": "22.1.0-preview-4ef4efd7",
"@metamask-previews/signature-controller": "29.0.0-preview-4ef4efd7",
"@metamask-previews/token-search-discovery-controller": "3.2.0-preview-4ef4efd7",
"@metamask-previews/transaction-controller": "56.3.0-preview-4ef4efd7",
"@metamask-previews/user-operation-controller": "35.0.0-preview-4ef4efd7"
}

@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@metamaskbot publish-preview

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
"@metamask-previews/accounts-controller": "29.0.0-preview-c4b7ea2e",
"@metamask-previews/address-book-controller": "6.0.3-preview-c4b7ea2e",
"@metamask-previews/announcement-controller": "7.0.3-preview-c4b7ea2e",
"@metamask-previews/app-metadata-controller": "1.0.0-preview-c4b7ea2e",
"@metamask-previews/approval-controller": "7.1.3-preview-c4b7ea2e",
"@metamask-previews/assets-controllers": "66.0.0-preview-c4b7ea2e",
"@metamask-previews/base-controller": "8.0.1-preview-c4b7ea2e",
"@metamask-previews/bridge-controller": "29.0.0-preview-c4b7ea2e",
"@metamask-previews/bridge-status-controller": "26.0.0-preview-c4b7ea2e",
"@metamask-previews/build-utils": "3.0.3-preview-c4b7ea2e",
"@metamask-previews/chain-agnostic-permission": "0.7.0-preview-c4b7ea2e",
"@metamask-previews/composable-controller": "11.0.0-preview-c4b7ea2e",
"@metamask-previews/controller-utils": "11.9.0-preview-c4b7ea2e",
"@metamask-previews/delegation-controller": "0.3.0-preview-c4b7ea2e",
"@metamask-previews/earn-controller": "0.14.0-preview-c4b7ea2e",
"@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-c4b7ea2e",
"@metamask-previews/ens-controller": "16.0.0-preview-c4b7ea2e",
"@metamask-previews/error-reporting-service": "1.0.0-preview-c4b7ea2e",
"@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-c4b7ea2e",
"@metamask-previews/gas-fee-controller": "23.0.0-preview-c4b7ea2e",
"@metamask-previews/json-rpc-engine": "10.0.3-preview-c4b7ea2e",
"@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-c4b7ea2e",
"@metamask-previews/keyring-controller": "22.0.0-preview-c4b7ea2e",
"@metamask-previews/logging-controller": "6.0.4-preview-c4b7ea2e",
"@metamask-previews/message-manager": "12.0.1-preview-c4b7ea2e",
"@metamask-previews/multichain": "4.1.0-preview-c4b7ea2e",
"@metamask-previews/multichain-api-middleware": "0.4.0-preview-c4b7ea2e",
"@metamask-previews/multichain-network-controller": "0.7.0-preview-c4b7ea2e",
"@metamask-previews/multichain-transactions-controller": "1.0.0-preview-c4b7ea2e",
"@metamask-previews/name-controller": "8.0.3-preview-c4b7ea2e",
"@metamask-previews/network-controller": "23.5.1-preview-c4b7ea2e",
"@metamask-previews/notification-services-controller": "8.0.0-preview-c4b7ea2e",
"@metamask-previews/permission-controller": "11.0.6-preview-c4b7ea2e",
"@metamask-previews/permission-log-controller": "3.0.3-preview-c4b7ea2e",
"@metamask-previews/phishing-controller": "12.5.0-preview-c4b7ea2e",
"@metamask-previews/polling-controller": "13.0.0-preview-c4b7ea2e",
"@metamask-previews/preferences-controller": "18.1.0-preview-c4b7ea2e",
"@metamask-previews/profile-sync-controller": "15.0.0-preview-c4b7ea2e",
"@metamask-previews/queued-request-controller": "10.0.0-preview-c4b7ea2e",
"@metamask-previews/rate-limit-controller": "6.0.3-preview-c4b7ea2e",
"@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-c4b7ea2e",
"@metamask-previews/sample-controllers": "0.1.0-preview-c4b7ea2e",
"@metamask-previews/seedless-onboarding-controller": "0.0.0-preview-c4b7ea2e",
"@metamask-previews/selected-network-controller": "22.1.0-preview-c4b7ea2e",
"@metamask-previews/signature-controller": "29.0.0-preview-c4b7ea2e",
"@metamask-previews/token-search-discovery-controller": "3.2.0-preview-c4b7ea2e",
"@metamask-previews/transaction-controller": "56.3.0-preview-c4b7ea2e",
"@metamask-previews/user-operation-controller": "35.0.0-preview-c4b7ea2e"
}

Matt561
Matt561 previously approved these changes May 30, 2025

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the primary changes in this PR are still missing from the changelog. Some were easy to spot in the code and so I've noted those, but I didn't make suggestions for everything. Could you go through the changes and make sure everything that consumers should know about are documented appropriately?

Comment threadpackages/earn-controller/CHANGELOG.md Outdated
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/CHANGELOG.md Outdated
Comment threadpackages/earn-controller/CHANGELOG.md Outdated
Comment threadpackages/earn-controller/CHANGELOG.md Outdated
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some more comments on things that may be worth documenting if my previous comment was unclear.

Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts
Comment threadpackages/earn-controller/src/EarnController.ts
@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch from 23f2e6c to 62585faCompareMay 31, 2025 01:20
@nickewansmith
nickewansmith requested a review from mcmireMay 31, 2025 01:22
@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

I left some more comments on things that may be worth documenting if my previous comment was unclear.

Crystal 👍🏽. Thanks again for the feedback ser @mcmire. I have revised the changelog per your feedback.

Matt561
Matt561 previously approved these changes Jun 2, 2025

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better, thanks! Just one more thing.

Comment threadpackages/earn-controller/CHANGELOG.md Outdated
@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch from 0768fe0 to 9a52698CompareJune 2, 2025 21:45
Comment threadpackages/earn-controller/package.json Outdated
@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch from 7c368b1 to d5d9913CompareJune 2, 2025 21:53
Matt561
Matt561 previously approved these changes Jun 2, 2025
@nickewansmith
nickewansmithforce-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch from 2fac0d5 to 26f282aCompareJune 2, 2025 21:57

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, everything LGTM!

@Matt561
Matt561 self-requested a review June 2, 2025 21:58
@nickewansmith
nickewansmith merged commit 90746c9 into mainJun 2, 2025
@nickewansmith
nickewansmith deleted the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch June 2, 2025 22:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickewansmith@mcmire@Matt561