Uh oh!
There was an error while loading. Please reload this page.
feat: add lending functionality to controller - #5828
Conversation
e98615a to
cf6f81fCompareReview the following changes in direct dependencies. Learn more about Socket for GitHub.
|
dd2a4d6 to
6a84ad7Comparenickewansmith
commented
May 19, 2025
@metamaskbot publish-preview |
6a84ad7 to
37f78daComparenickewansmith
commented
May 20, 2025
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
nickewansmith
commented
May 21, 2025
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
e4411aa to
8fef31fComparenickewansmith
commented
May 28, 2025
@metamaskbot publish-preview |
1 similar comment
nickewansmith
commented
May 28, 2025
@metamaskbot publish-preview |
mcmire
left a comment
There was a problem hiding this comment.
I've made some suggestions for the changelog. It would be good to roll back the version bump and also get more context around exporting @metamask/stake-sdk.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nickewansmith
commented
May 29, 2025
Thanks for the review and pointers @mcmire I will take a look soon and adjust. |
d2b9c33 to
4ef4efdComparenickewansmith
commented
May 29, 2025
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
nickewansmith
commented
May 30, 2025
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mcmire
left a comment
There was a problem hiding this comment.
It seems that the primary changes in this PR are still missing from the changelog. Some were easy to spot in the code and so I've noted those, but I didn't make suggestions for everything. Could you go through the changes and make sure everything that consumers should know about are documented appropriately?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mcmire
left a comment
There was a problem hiding this comment.
I left some more comments on things that may be worth documenting if my previous comment was unclear.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…pers-and-state-in-earn-controller
23f2e6c to
62585faComparenickewansmith
commented
May 31, 2025
Crystal 👍🏽. Thanks again for the feedback ser @mcmire. I have revised the changelog per your feedback. |
mcmire
left a comment
There was a problem hiding this comment.
This looks much better, thanks! Just one more thing.
Uh oh!
There was an error while loading. Please reload this page.
0768fe0 to
9a52698CompareUh oh!
There was an error while loading. Please reload this page.
7c368b1 to
d5d9913Compare2fac0d5 to
26f282aCompare…pers-and-state-in-earn-controller
Explanation
References
Fixes https://consensyssoftware.atlassian.net/browse/STAKE-904
Checklist