Uh oh!
There was an error while loading. Please reload this page.
fix(bridge-status-controller)!: use SnapKeyring.submitRequest to dispatch Snap keyring requests - #5924
Draft
ccharly wants to merge 2 commits into
Draft
fix(bridge-status-controller)!: use SnapKeyring.submitRequest to dispatch Snap keyring requests#5924ccharly wants to merge 2 commits into
ccharly wants to merge 2 commits into
Conversation
ccharlyforce-pushed
the
fix/use-snap-keyring-in-bridge
branch
from
June 5, 2025 08:27
8512029 to
bd4ede5Compareccharly
commented
Jun 5, 2025
Comment on lines
2857
to
2884
ContributorAuthor
There was a problem hiding this comment.
We no longer uses the SnapController to dispatch those request.
ccharly
commented
Jun 5, 2025
ContributorAuthor
There was a problem hiding this comment.
Removed this dependency now that we rely solely on the SnapKeyring to dispatch keyring requests.
…tch Snap keyring requests
ccharlyforce-pushed
the
fix/use-snap-keyring-in-bridge
branch
from
June 9, 2025 14:30
bd4ede5 to
9476427CompareContributorAuthor
@metamaskbot publish-preview |
1 similar comment
ccharly
commented
Jun 9, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
I missed this when introducing the
KeyringRequest.originfeature.The main problem is that this controller is dispatching "raw Snap request", thus, preventing any type-checking when doing keyring API updades.
By using
SnapKeyringthis should prevent this kind of problems in the future and it aligns well on how other controllers interact with the Snap keyring requests!References
N/A
Changelog
Checklist