Skip to content

Check duplicates data before adding or creating new backup - #5955

Merged
chaitanyapotti merged 233 commits into
mainfrom
fix/dupes-check
Jun 13, 2025
Merged

Check duplicates data before adding or creating new backup#5955
chaitanyapotti merged 233 commits into
mainfrom
fix/dupes-check

Conversation

@lwin-kyaw

Copy link
Copy Markdown
Contributor

Explanation

This PR adds a duplicate data check before user adds new SecretData (Mnemonics or PrivateKey).
If the data is already existed in the controller backup state, we will skip adding to the metadata store.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

lwin-kyawand others added 30 commits April 10, 2025 12:40
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Mask/core into feat/seedless-onboarding-controller
@lwin-kyaw
lwin-kyaw requested a review from a team as a code ownerJune 11, 2025 07:49
@lwin-kyaw

Copy link
Copy Markdown
ContributorAuthor

@metamaskbot publish-preview

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
"@metamask-previews/account-tree-controller": "0.1.0-preview-5dcecbb7",
"@metamask-previews/accounts-controller": "30.0.0-preview-5dcecbb7",
"@metamask-previews/address-book-controller": "6.1.0-preview-5dcecbb7",
"@metamask-previews/announcement-controller": "7.0.3-preview-5dcecbb7",
"@metamask-previews/app-metadata-controller": "1.0.0-preview-5dcecbb7",
"@metamask-previews/approval-controller": "7.1.3-preview-5dcecbb7",
"@metamask-previews/assets-controllers": "68.1.0-preview-5dcecbb7",
"@metamask-previews/base-controller": "8.0.1-preview-5dcecbb7",
"@metamask-previews/bridge-controller": "32.1.1-preview-5dcecbb7",
"@metamask-previews/bridge-status-controller": "29.1.0-preview-5dcecbb7",
"@metamask-previews/build-utils": "3.0.3-preview-5dcecbb7",
"@metamask-previews/chain-agnostic-permission": "0.7.0-preview-5dcecbb7",
"@metamask-previews/composable-controller": "11.0.0-preview-5dcecbb7",
"@metamask-previews/controller-utils": "11.10.0-preview-5dcecbb7",
"@metamask-previews/delegation-controller": "0.4.0-preview-5dcecbb7",
"@metamask-previews/earn-controller": "1.1.0-preview-5dcecbb7",
"@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-5dcecbb7",
"@metamask-previews/ens-controller": "16.0.0-preview-5dcecbb7",
"@metamask-previews/error-reporting-service": "1.0.0-preview-5dcecbb7",
"@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-5dcecbb7",
"@metamask-previews/foundryup": "1.0.0-preview-5dcecbb7",
"@metamask-previews/gas-fee-controller": "23.0.0-preview-5dcecbb7",
"@metamask-previews/json-rpc-engine": "10.0.3-preview-5dcecbb7",
"@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-5dcecbb7",
"@metamask-previews/keyring-controller": "22.0.2-preview-5dcecbb7",
"@metamask-previews/logging-controller": "6.0.4-preview-5dcecbb7",
"@metamask-previews/message-manager": "12.0.1-preview-5dcecbb7",
"@metamask-previews/multichain": "4.1.0-preview-5dcecbb7",
"@metamask-previews/multichain-api-middleware": "0.4.0-preview-5dcecbb7",
"@metamask-previews/multichain-network-controller": "0.8.0-preview-5dcecbb7",
"@metamask-previews/multichain-transactions-controller": "2.0.0-preview-5dcecbb7",
"@metamask-previews/name-controller": "8.0.3-preview-5dcecbb7",
"@metamask-previews/network-controller": "23.6.0-preview-5dcecbb7",
"@metamask-previews/notification-services-controller": "10.0.0-preview-5dcecbb7",
"@metamask-previews/permission-controller": "11.0.6-preview-5dcecbb7",
"@metamask-previews/permission-log-controller": "3.0.3-preview-5dcecbb7",
"@metamask-previews/phishing-controller": "12.5.0-preview-5dcecbb7",
"@metamask-previews/polling-controller": "13.0.0-preview-5dcecbb7",
"@metamask-previews/preferences-controller": "18.1.0-preview-5dcecbb7",
"@metamask-previews/profile-sync-controller": "17.1.0-preview-5dcecbb7",
"@metamask-previews/queued-request-controller": "10.0.0-preview-5dcecbb7",
"@metamask-previews/rate-limit-controller": "6.0.3-preview-5dcecbb7",
"@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-5dcecbb7",
"@metamask-previews/sample-controllers": "0.1.0-preview-5dcecbb7",
"@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-5dcecbb7",
"@metamask-previews/selected-network-controller": "22.1.0-preview-5dcecbb7",
"@metamask-previews/signature-controller": "30.0.0-preview-5dcecbb7",
"@metamask-previews/token-search-discovery-controller": "3.3.0-preview-5dcecbb7",
"@metamask-previews/transaction-controller": "57.2.0-preview-5dcecbb7",
"@metamask-previews/user-operation-controller": "36.0.0-preview-5dcecbb7"
}

@lwin-kyaw
lwin-kyaw requested a review from a team as a code ownerJune 11, 2025 07:58
tuna1207
tuna1207 previously approved these changes Jun 11, 2025

@tuna1207tuna1207 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lwin-kyaw
lwin-kyaw requested review from a team and chaitanyapottiJune 13, 2025 05:12
Base automatically changed from feat/seedless-refresh-token to mainJune 13, 2025 08:06
@lwin-kyaw
lwin-kyaw dismissed tuna1207’s stale reviewJune 13, 2025 08:06

The base branch was changed.

chaitanyapotti
chaitanyapotti previously approved these changes Jun 13, 2025

@chaitanyapottichaitanyapotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti
chaitanyapotti enabled auto-merge (squash) June 13, 2025 08:43
@chaitanyapotti
chaitanyapotti merged commit e52edd6 into mainJun 13, 2025
@chaitanyapotti
chaitanyapotti deleted the fix/dupes-check branch June 13, 2025 08:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lwin-kyaw@chaitanyapotti@tuna1207@ieow