Skip to content

16.0.0 - #596

Merged
adonesky1 merged 5 commits into
mainfrom
release/16.0.0
Sep 16, 2021
Merged

16.0.0#596
adonesky1 merged 5 commits into
mainfrom
release/16.0.0

Conversation

@adonesky1

@adonesky1adonesky1 commented Sep 16, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

This a release candidate for v.16.0.0

[16.0.0]

Changed

  • BREAKING: Remove Synctokens method from the tokens-service (#590)
    • This is breaking for any consumers of this method.
  • Enable default caching for token-service (#594)

Fixed

  • Fix bug that allowed for multiple fetch requests instantiate from getGasFeeEstimatesAndStartPolling (#586)

@adonesky1
adonesky1 requested a review from a team as a code ownerSeptember 16, 2021 18:33
@adonesky1adonesky1 mentioned this pull request Sep 16, 2021
Closed
Gudahtt
Gudahtt reviewed Sep 16, 2021
View reviewed changes
Comment threadCHANGELOG.md Outdated
@adonesky1@Gudahtt
Update CHANGELOG.md
bacbde6
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
Gudahtt reviewed Sep 16, 2021
View reviewed changes
Comment threadCHANGELOG.md
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
- **BREAKING**: Remove `syncTokens` method from the TokenListController ([#590](https://github.com/MetaMask/controllers/pull/590))
- This is breaking for any consumers of this method.
- Enable default caching for token-service ([#594](https://github.com/MetaMask/controllers/pull/594))
- Set tokenList to empty object in test networks ([#588](https://github.com/MetaMask/controllers/pull/588))

@GudahttGudahttSep 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be describing something internal - it doesn't make clear what the actual change was for consumers. It's not clear to me either from reading the PR.

My best guess is that this is a bug fix, and that the change was to clear the dynamic token list when switching to a network not supported by our token list API. Does that sound correct? cc @NiranjanaBinoy@danjm

@danjmdanjmSep 16, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gudahtt that is correct

Comment threadCHANGELOG.md Outdated
adonesky1and others added 3 commits September 16, 2021 13:57
@adonesky1@Gudahtt
Update CHANGELOG.md
befdc7c
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@adonesky1@Gudahtt
Update CHANGELOG.md
66eefcd
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@adonesky1
update changelog
01f8c96
Gudahtt
Gudahtt approved these changes Sep 16, 2021
View reviewed changes

@GudahttGudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1
adonesky1 merged commit 26be9d2 into mainSep 16, 2021
@adonesky1
adonesky1 deleted the release/16.0.0 branch September 16, 2021 19:32
@Gudahtt

Gudahtt commented Sep 16, 2021

Copy link
Copy Markdown
Member

A new version of the package @metamask/controllers (16.0.0) was published at 2021-09-16T19:36:16.027Z from
[redacted]. The shasum of this package was 2c13550a5c7d47a0061a3f3de25e6becdc8531ad.

amitabh94 pushed a commit to amitabh94/core that referenced this pull request Jun 16, 2026
@cryptodev-2s
chore: remove sinon, use jest fake timers (MetaMask#596)
2d05101
Core doesn't use sinon. This package only used it for
`useFakeTimers()` and a small `advanceTime` helper, both of
which have direct Jest equivalents:
- sinon.useFakeTimers() / clock.restore() ->
jest.useFakeTimers() / jest.useRealTimers()
- clock.tickAsync(stepSize) ->
jest.advanceTimersByTimeAsync(stepSize)
- `advanceTime({ clock, duration, stepSize })` ->
`advanceTime({ duration, stepSize })` (clock arg dropped)
Also bumps ts-jest ^29.1.4 -> ^29.2.5 to match core.
Test suite remains at 196/196 and now runs in ~2.5s (down from ~6s).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GudahttGudahttGudahtt approved these changes
@danjmdanjmAwaiting requested review from danjm
@NiranjanaBinoyNiranjanaBinoyAwaiting requested review from NiranjanaBinoy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adonesky1@Gudahtt@danjm