Skip to content

use approvalType.TransactionBatch - #5971

Merged
vinistevam merged 4 commits into
mainfrom
fix/use-approval-type-batch
Jun 13, 2025
Merged

use approvalType.TransactionBatch#5971
vinistevam merged 4 commits into
mainfrom
fix/use-approval-type-batch

Conversation

@vinistevam

@vinistevamvinistevam commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Explanation

This PR aims to change the hardcoded transaction_batch to use the ApprovalType.TransactionBatch from Controller utils, and some cleanup in unit tests.

References

Fixeshttps://github.com/MetaMask/MetaMask-planning/issues/5143

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@vinistevam
vinistevam marked this pull request as ready for review June 12, 2025 12:51
@vinistevam
vinistevam requested a review from a team as a code ownerJune 12, 2025 12:51
@vinistevam
vinistevam merged commit 056be3e into mainJun 13, 2025
@vinistevam
vinistevam deleted the fix/use-approval-type-batch branch June 13, 2025 13:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vinistevam@pedronfigueiredo