Uh oh!
There was an error while loading. Please reload this page.
fix: prevent TokenBalancesController updating account balance to 0 while multicall contract failed - #5975
Merged
stanleyyconsensys merged 3 commits intoJun 13, 2025
Conversation
TokenBalancesController updating account balance to 0 while multicall contract failedContributorAuthor
There was a problem hiding this comment.
as the default state is empty, if the balance not update, the state should remain the same
Contributor
There was a problem hiding this comment.
why the contract call is failing on SEI ?
ContributorAuthor
There was a problem hiding this comment.
Infura block height not sync issue, but anyway, it can be any reason from any RPC
salimtb
commented
Jun 13, 2025
Contributor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
stanleyyconsensysforce-pushed
the
fix/token-balance-update-multicall-contract
branch
from
June 13, 2025 09:25
4193b35 to
da70a75Comparestanleyyconsensys
enabled auto-merge (squash)
June 13, 2025 09:29
stanleyyconsensys
deleted the
fix/token-balance-update-multicall-contract
branch
June 13, 2025 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fix:
TokenBalancesController updating account balance to 0 while multicall contract failed
in
AssetsControllers/TokenBalancesController->updateBalancesByChainIdit use multicall contract to continually poll the balance and update the balance for the account,
however even if the contract request failed, it will continue to update
the root cause is because the multicall return an array of MulticallResult object even it failed, but the value of the balance may become undefined
hence, the
updateBalancesByChainIdwill continue using this value to process the logic, and result update the balance to 0Attached the extension screen that impacted by above logic
References
Changelog
Checklist