Skip to content

Removed recoveryRatelimitCache from the Seedless controller state - #5976

Merged
chaitanyapotti merged 239 commits into
mainfrom
fix/remove-ratelimit-state
Jun 13, 2025
Merged

Removed recoveryRatelimitCache from the Seedless controller state#5976
chaitanyapotti merged 239 commits into
mainfrom
fix/remove-ratelimit-state

Conversation

@lwin-kyaw

Copy link
Copy Markdown
Contributor

Explanation

This PR removes the recoveryRatelimitCache data from the controller state.
Previously, the state was needed to address the state sync between devices because of the inaccurate rate-limit blocking time from the server. Recently, the fixes for this were addressed in the Server as well as in the SDK, hence the state data are redundant and will not work anymore.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

lwin-kyawand others added 30 commits April 10, 2025 12:40
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Controller.ts
Co-authored-by: himanshuchawla009 <himanshuchawla2014@gmail.com>
…Mask/core into feat/seedless-onboarding-controller
@lwin-kyaw
lwin-kyaw requested review from a team as code ownersJune 13, 2025 08:53

@chaitanyapottichaitanyapotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti
chaitanyapotti enabled auto-merge (squash) June 13, 2025 09:32
@chaitanyapotti
chaitanyapotti merged commit 41b5bc6 into mainJun 13, 2025
@chaitanyapotti
chaitanyapotti deleted the fix/remove-ratelimit-state branch June 13, 2025 09:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lwin-kyaw@chaitanyapotti@tuna1207@ieow