Uh oh!
There was an error while loading. Please reload this page.
feat: use the new onAssetsMarketData handler - #6035
Merged
Merged
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
salimtb
commented
Jun 25, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
salimtb
marked this pull request as ready for review
June 26, 2025 09:06
GuillaumeRx
requested changes
Jun 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeRx
requested changes
Jun 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeRx
previously requested changes
Jun 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
salimtb
marked this pull request as draft
June 26, 2025 10:41
salimtb
marked this pull request as draft
June 26, 2025 10:41
salimtb
marked this pull request as draft
June 26, 2025 10:41
salimtb
marked this pull request as draft
June 26, 2025 10:41
salimtbforce-pushed
the
fix/use-onAssetsMarketData-handler
branch
from
June 26, 2025 12:17
ef20063 to
58d06fdComparesalimtbforce-pushed
the
fix/use-onAssetsMarketData-handler
branch
from
June 26, 2025 12:54
f1867b7 to
ba933d9Comparesalimtb
marked this pull request as ready for review
June 26, 2025 12:54
GuillaumeRx
left a comment
Contributor
There was a problem hiding this comment.
Some small NITS otherwise LGTM ! Let's wait for the Snaps Platform release to merge.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeRx
requested changes
Jun 30, 2025
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeRx
previously approved these changes
Jun 30, 2025
gambinish
previously approved these changes
Jun 30, 2025
mcmire
reviewed
Jun 30, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
salimtb
dismissed stale reviews from cryptodev-2s, gambinish, and GuillaumeRx
via
July 1, 2025 09:59
a01473b
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ccharly
approved these changes
Jul 1, 2025
ccharly
left a comment
Contributor
There was a problem hiding this comment.
LGTM for accounts owned file (changelogs + package.jsons). I haven't review the code/logic.
GuillaumeRx
removed their request for review
July 1, 2025 13:08
jpsains
approved these changes
Jul 1, 2025
infiniteflower
approved these changes
Jul 1, 2025
github-merge-queueBot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jul 8, 2025
## **Description** This PR bumps: - `@metamask/profile-sync-controller` to `^20.0.0` Updates from the package changelog since `^18.0.0`: ```md ## [20.0.0] ### Added - Add new `AuthenticationController:getUserProfileMetaMetrics` method ([#6068](MetaMask/core#6068)) - This method fetches data using the Authentication API, returning all MetaMetrics sessions related to the currently authenticated user, in the form of `typeof UserProfileMetaMetrics` ### Changed - **BREAKING:** Bump peer dependency `@metamask/snaps-controllers` from `^12.0.0` to `^14.0.0` ([#6035](MetaMask/core#6035)) - Bump `@metamask/snaps-sdk` from `^7.1.0` to `^9.0.0` ([#6035](MetaMask/core#6035)) - Bump `@metamask/snaps-utils` from `^9.4.0` to `^11.0.0` ([#6035](MetaMask/core#6035)) ## [19.0.0] ### Changed - **BREAKING:** Bump peer dependency `@metamask/accounts-controller` to `^31.0.0` ([#5999](MetaMask/core#5999)) - **BREAKING:** Bump peer dependency `@metamask/network-controller` to `^24.0.0` ([#5999](MetaMask/core#5999)) ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
github-merge-queueBot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jul 8, 2025
## **Description** This PR bumps: - `@metamask/profile-sync-controller` to `^20.0.0` Updates from the package changelog since `^18.0.0`: ```md ## [20.0.0] ### Added - Add new `AuthenticationController:getUserProfileMetaMetrics` method ([#6068](MetaMask/core#6068)) - This method fetches data using the Authentication API, returning all MetaMetrics sessions related to the currently authenticated user, in the form of `typeof UserProfileMetaMetrics` ### Changed - **BREAKING:** Bump peer dependency `@metamask/snaps-controllers` from `^12.0.0` to `^14.0.0` ([#6035](MetaMask/core#6035)) - Bump `@metamask/snaps-sdk` from `^7.1.0` to `^9.0.0` ([#6035](MetaMask/core#6035)) - Bump `@metamask/snaps-utils` from `^9.4.0` to `^11.0.0` ([#6035](MetaMask/core#6035)) ## [19.0.0] ### Changed - **BREAKING:** Bump peer dependency `@metamask/accounts-controller` to `^31.0.0` ([#5999](MetaMask/core#5999)) - **BREAKING:** Bump peer dependency `@metamask/network-controller` to `^24.0.0` ([#5999](MetaMask/core#5999)) ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
github-merge-queueBot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Jul 8, 2025
## **Description** This PR bumps: - `@metamask/profile-sync-controller` to `^20.0.0` Updates from the package changelog since `^18.0.0`: ```md ## [20.0.0] ### Added - Add new `AuthenticationController:getUserProfileMetaMetrics` method ([#6068](MetaMask/core#6068)) - This method fetches data using the Authentication API, returning all MetaMetrics sessions related to the currently authenticated user, in the form of `typeof UserProfileMetaMetrics` ### Changed - **BREAKING:** Bump peer dependency `@metamask/snaps-controllers` from `^12.0.0` to `^14.0.0` ([#6035](MetaMask/core#6035)) - Bump `@metamask/snaps-sdk` from `^7.1.0` to `^9.0.0` ([#6035](MetaMask/core#6035)) - Bump `@metamask/snaps-utils` from `^9.4.0` to `^11.0.0` ([#6035](MetaMask/core#6035)) ## [19.0.0] ### Changed - **BREAKING:** Bump peer dependency `@metamask/accounts-controller` to `^31.0.0` ([#5999](MetaMask/core#5999)) - **BREAKING:** Bump peer dependency `@metamask/network-controller` to `^24.0.0` ([#5999](MetaMask/core#5999)) ``` ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: use the new onAssetsMarketData handler
Explanation
Current State and Problem
The
MultichainAssetsRatesControllercurrently uses the deprecatedonAssetsConversionhandler to fetch asset market data from Snaps. This handler interface is outdated and doesn't align with the current Snaps SDK architecture, which has evolved to provide better separation of concerns and more robust data handling.Solution
This PR updates the
MultichainAssetsRatesControllerto use the newonAssetsMarketDatahandler in addition ofonAssetsConversion. This change:onAssetsMarketDatahandler provides a more standardized and reliable interface for fetching asset market data from SnapsDependency Updates
Alongside the main functional change, this PR also updates several Snaps-related dependencies across multiple packages to ensure compatibility and access to the latest features:
@metamask/snaps-sdk:^7.1.0→^9.0.0@metamask/snaps-utils:^9.4.0→^11.0.0@metamask/snaps-controllers:^12.3.1→^14.0.1These updates are necessary because:
onAssetsMarketDatahandler is available in the updated SDK versionsPackage-Specific Changes
The changes affect multiple packages because they all depend on the Snaps ecosystem. Each package's changelog has been updated to reflect the specific dependency changes that apply to it, ensuring transparency for consumers.
References
Checklist
Note: All changelogs have been updated for the affected packages:
@metamask/assets-controllers@metamask/account-tree-controller@metamask/accounts-controller@metamask/bridge-controller@metamask/bridge-status-controller@metamask/multichain-transactions-controller@metamask/profile-sync-controller