Uh oh!
There was an error while loading. Please reload this page.
feat: reduce KDF computing cost on clients - #6097
Open
mathieuartu wants to merge 27 commits into
Open
Conversation
mathieuartu
commented
Jul 10, 2025
ContributorAuthor
@metamaskbot publish-preview |
mathieuartu
commented
Jul 10, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mirceanis
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
Perhaps we can rephrase the changelog to reenforce the reason for this change.
Since this PR deals with encryption "soft" migration I'd take the opportunity to make sure that future "hard" migrations fail gracefully, meaning that clients don't fail entire operations if one of the entries does not decrypt. See lines like if (encryptedData.v === '1').... else throw.
WDYT @mathieuartu ?
Uh oh!
There was an error while loading. Please reload this page.
mathieuartu
marked this pull request as ready for review
July 16, 2025 13:26
mirceanis
previously approved these changes
Jul 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
mathieuartu
commented
Jul 16, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mathieuartu
marked this pull request as draft
July 16, 2025 16:35
Mrtenz
reviewed
Jul 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
mathieuartuforce-pushed
the
feat/kdf-performance-2-dumbed-down
branch
from
July 17, 2025 18:57
159efb2 to
ffa6d7aComparemathieuartu
commented
Jul 17, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mathieuartu
commented
Jul 18, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mathieuartu
marked this pull request as ready for review
July 18, 2025 09:37
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mathieuartu
marked this pull request as draft
July 18, 2025 10:21
mathieuartu
marked this pull request as ready for review
July 18, 2025 10:21
mathieuartu
commented
Jul 18, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
fabiobozzo
previously approved these changes
Jul 18, 2025
mathieuartu
marked this pull request as draft
July 22, 2025 15:16
mathieuartu
commented
Jul 22, 2025
ContributorAuthor
Going back to draft again as it seems to be working fine now but may have introduced a UI bug on mobile when adding or renaming accounts. Investigating. |
mathieuartu
marked this pull request as ready for review
July 25, 2025 12:41
4 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Nscryptparameter used to compute the encryption key in order to significantly increase performance on clients.The tests below have been done measuring 30 consecutive clean onboardings and the time it took to encrypt or decrypt the first entry (before caching the key from the KDF)
References
Fixes:
Test drive client PRs:
Changelog
Checklist
Note
Lowers scrypt N and introduces a new shared salt with auto-migration, adds encrypt/decrypt callbacks, updates caching/derivation logic, and refreshes tests and changelog.
SCRYPT_N_V2 = 2) and introduceSHARED_SALT_V2.doesEntryNeedReEncryptionand auto-migrate entries encrypted with old salt or oldN.onEncrypt/onDecrypt) and fire them with payload metadata.sha2import.getItem,getAllFeatureItems,setItem,batchSetItems.EncryptedPayload), constants/plumbing adjustments.config.encryption.onEncrypt/onDecryptand forward to SDK in all storage operations.N/salt, and caching behavior; update CHANGELOG under Unreleased.Written by Cursor Bugbot for commit b5439f2. This will update automatically on new commits. Configure here.