Uh oh!
There was an error while loading. Please reload this page.
Seedless controller: Add "@noble" dependencies as main dependencies - #6101
Merged
Conversation
matthiasgeihsforce-pushed
the
mg/fix-seedless-dependencies
branch
from
July 14, 2025 09:15
c8788f9 to
d2fe10fComparematthiasgeihsforce-pushed
the
mg/fix-seedless-dependencies
branch
from
July 14, 2025 09:27
d2fe10f to
74026d4CompareContributor
There was a problem hiding this comment.
Nit: instead of using no-changelog could we add a changelog entry for this bump
Comment on lines
106
to
107
Contributor
There was a problem hiding this comment.
Nit: instead of using no-changelog could we add a changelog entries for these bumps
Comment on lines
54
to
56
Contributor
There was a problem hiding this comment.
Nit: instead of using no-changelog could we add a changelog entries for these bumps and that they are being now used as dependencies
matthiasgeihsforce-pushed
the
mg/fix-seedless-dependencies
branch
from
July 15, 2025 20:16
2983e5c to
c0e611aComparematthiasgeihs
commented
Jul 15, 2025
ContributorAuthor
rebased |
matthiasgeihsforce-pushed
the
mg/fix-seedless-dependencies
branch
from
July 16, 2025 11:47
c0e611a to
29a2046Comparematthiasgeihsforce-pushed
the
mg/fix-seedless-dependencies
branch
from
August 4, 2025 08:46
29a2046 to
79b0b08Comparecryptotavares
approved these changes
Aug 4, 2025
mathieuartu
commented
Aug 4, 2025
Contributor
Thanks for doing this. LGTM! I know this could be a hassle, but considering how critical backup & sync features are, could we please make sure to include client test-drive PRs to make sure:
|
mathieuartu
commented
Aug 4, 2025
Contributor
This can be done following those steps:
|
matthiasgeihs
commented
Aug 4, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthiasgeihs
commented
Aug 4, 2025
ContributorAuthor
@mathieuartu have created PRs in mobile and extension, please have a look. |
mathieuartu
approved these changes
Aug 4, 2025
mathieuartu
left a comment
Contributor
There was a problem hiding this comment.
Thanks a ton! Verified E2Es and did manual test runs, all seems to be working fine :)
matthiasgeihsforce-pushed
the
mg/fix-seedless-dependencies
branch
from
August 4, 2025 15:20
79b0b08 to
b69aa52Comparematthiasgeihs
enabled auto-merge (squash)
August 4, 2025 15:20
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The dependencies
@noble/hashes,@noble/ciphers,@noble/curveswere mistakenly listed as dev-dependencies inseedless-controller. Moving them to main dependencies here.Also upgrading all
@nobledependencies to most recent version. In particular,@noble/ciphershas now a v1 which is audited.References
Changelog
Checklist