Uh oh!
There was an error while loading. Please reload this page.
chore: Update Jest config to map next export to source correctly - #6349
Merged
Conversation
Gudahttforce-pushed
the
fix-tests-that-use-base-controller-next-export
branch
from
August 20, 2025 18:13
7262b93 to
a85fa14Compare4 tasks
Gudahtt
marked this pull request as ready for review
August 20, 2025 18:32
Gudahttforce-pushed
the
fix-tests-that-use-base-controller-next-export
branch
from
August 20, 2025 18:32
a85fa14 to
1ccaefdCompareTests that used the `@metamask/base-controller/next` export were not working correctly until after a build was completed. They were using the built code rather than the source code. On CI the tests run without any build, so they would always fail. This was resolved up updating the TSConfig and Jest config to map the `next` export to the correct source code. This unblocks #6335 as well as other controller migrations to the upcoming BaseController version.
Gudahttforce-pushed
the
fix-tests-that-use-base-controller-next-export
branch
from
August 21, 2025 12:15
1ccaefd to
fd4a4f8CompareGudahtt
enabled auto-merge (squash)
August 21, 2025 12:19
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Tests that used the
@metamask/base-controller/nextexport were not working correctly until after a build was completed. They were using the built code rather than the source code. On CI the tests run without any build, so they would always fail.This was resolved up updating the TSConfig and Jest config to map the
nextexport to the correct source code.This unblocks #6335 as well as other controller migrations to the upcoming BaseController version.
References
Relates to #5626
Checklist