Skip to content

refactor: migrate AppMetadataController to @metamask/messenger - #6385

Merged
mikesposito merged 19 commits into
mainfrom
mikesposito/messenger/app-metadata-controller
Oct 27, 2025
Merged

refactor: migrate AppMetadataController to @metamask/messenger#6385
mikesposito merged 19 commits into
mainfrom
mikesposito/messenger/app-metadata-controller

Conversation

@mikesposito

@mikespositomikesposito commented Aug 26, 2025

Copy link
Copy Markdown
Member

Explanation

This PR migrates the AppMetadataController class to the new @metamask/messenger comm system, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates AppMetadataController to the new @metamask/messenger, updates metadata flag names, and aligns tests and configs with base-controller/next.

  • App Metadata Controller:
    • Migrate from RestrictedMessenger (@metamask/base-controller) to Messenger (@metamask/messenger); update types and construction of namespaced messengers in tests.
    • Update imports to @metamask/base-controller/next and use BaseController from next.
    • Rename metadata flag anonymous to includeInDebugSnapshot; update deriveStateFromMetadata usages.
    • Add dependency @metamask/messenger and update TS references (tsconfig.json, tsconfig.build.json).
    • Update CHANGELOG.md with BREAKING changes.
  • Docs/Repo:
    • README dependency graph: add app_metadata_controller --> messenger link.

Written by Cursor Bugbot for commit 8232827. This will update automatically on new commits. Configure here.

@mikesposito
mikesposito marked this pull request as ready for review August 26, 2025 12:32
@mikesposito
mikesposito requested review from a team as code ownersAugust 26, 2025 12:32
cursor[bot]

This comment was marked as outdated.

@mikespositomikesposito mentioned this pull request Aug 26, 2025
43 tasks
Comment threadpackages/app-metadata-controller/src/AppMetadataController.test.ts Outdated
mcmire
mcmire previously approved these changes Aug 28, 2025

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire

Copy link
Copy Markdown
Collaborator

It's unclear to me why the code scanner workflow is failing. I don't see any issues.

@mikesposito
mikesposito enabled auto-merge (squash) September 23, 2025 10:05
mcmire
mcmire previously approved these changes Oct 7, 2025

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cursor[bot]

This comment was marked as outdated.

@cryptodev-2scryptodev-2s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito
mikesposito merged commit 03b9a16 into mainOct 27, 2025
256 of 257 checks passed
@mikesposito
mikesposito deleted the mikesposito/messenger/app-metadata-controller branch October 27, 2025 10:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mikesposito@mcmire@cryptodev-2s