Uh oh!
There was an error while loading. Please reload this page.
refactor: migrate AppMetadataController to @metamask/messenger - #6385
Merged
mikesposito merged 19 commits intoOct 27, 2025
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
43 tasks
mikesposito
commented
Aug 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
mcmire
commented
Aug 28, 2025
Collaborator
It's unclear to me why the code scanner workflow is failing. I don't see any issues. |
mikesposito
enabled auto-merge (squash)
September 23, 2025 10:05
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates the
AppMetadataControllerclass to the new@metamask/messengercomm system, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates
AppMetadataControllerto the new@metamask/messenger, updates metadata flag names, and aligns tests and configs withbase-controller/next.RestrictedMessenger(@metamask/base-controller) toMessenger(@metamask/messenger); update types and construction of namespaced messengers in tests.@metamask/base-controller/nextand useBaseControllerfromnext.anonymoustoincludeInDebugSnapshot; updatederiveStateFromMetadatausages.@metamask/messengerand update TS references (tsconfig.json,tsconfig.build.json).CHANGELOG.mdwith BREAKING changes.app_metadata_controller --> messengerlink.Written by Cursor Bugbot for commit 8232827. This will update automatically on new commits. Configure here.