Skip to content

refactor: migrate EnsController to @metamask/messenger - #6460

Merged
mikesposito merged 13 commits into
mainfrom
mikesposito/messenger/ens-controller
Oct 27, 2025
Merged

refactor: migrate EnsController to @metamask/messenger#6460
mikesposito merged 13 commits into
mainfrom
mikesposito/messenger/ens-controller

Conversation

@mikesposito

@mikespositomikesposito commented Sep 4, 2025

Copy link
Copy Markdown
Member

Explanation

This PR migrates EnsController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates EnsController to @metamask/messenger, updates metadata/types, and adjusts tests, configs, and docs accordingly.

  • Ens Controller:
    • Migrate from @metamask/base-controller messenger to @metamask/messenger and use @metamask/base-controller/next types (StateMetadata, controller actions/events).
    • Replace messagingSystem.call with messenger.call and update messenger types (EnsControllerActions, EnsControllerEvents).
    • Rename metadata anonymous to includeInDebugSnapshot.
  • Tests (packages/ens-controller/src/EnsController.test.ts):
    • Switch to new Messenger API: create root/controller messengers, delegate actions, and update types/util imports.
  • Dependencies/Config:
    • Add @metamask/messenger dependency; add TS project references to packages/messenger.
    • Update README dependency graph to include @metamask/messenger links for base_controller, ens_controller, and new eip_7702_internal_rpc_middleware edge.
    • Adjust ESLint warning threshold for import-x/order in EnsController.test.ts.
    • Update yarn.lock.
  • Changelog:
    • Note breaking change to use new Messenger and metadata rename; export EnsControllerActions and EnsControllerEvents.

Written by Cursor Bugbot for commit e37bf9a. This will update automatically on new commits. Configure here.

@mikesposito
mikesposito marked this pull request as ready for review September 4, 2025 10:53
@mikesposito
mikesposito requested review from a team as code ownersSeptember 4, 2025 10:53
@mikespositomikesposito mentioned this pull request Sep 4, 2025
43 tasks
Comment threadpackages/ens-controller/src/EnsController.ts
@mcmire

Copy link
Copy Markdown
Collaborator

Need to resolve conflicts :(

@cryptodev-2scryptodev-2s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito
mikesposito added this pull request to the merge queueOct 27, 2025
@FrederikBolding
FrederikBolding removed this pull request from the merge queue due to the queue being cleared Oct 27, 2025
@mikesposito
mikesposito added this pull request to the merge queueOct 27, 2025
Merged via the queue into main with commit 1b28614Oct 27, 2025
256 of 257 checks passed
@mikesposito
mikesposito deleted the mikesposito/messenger/ens-controller branch October 27, 2025 11:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mikesposito@mcmire@Gudahtt@cryptodev-2s