Skip to content

refactor: migrate TokenSearchDiscoveryController to @metamask/messenger - #6495

Merged
FrederikBolding merged 5 commits into
mainfrom
cryptodev-2s/messenger/token-search-discovery-controller
Oct 27, 2025
Merged

refactor: migrate TokenSearchDiscoveryController to @metamask/messenger#6495
FrederikBolding merged 5 commits into
mainfrom
cryptodev-2s/messenger/token-search-discovery-controller

Conversation

@cryptodev-2s

@cryptodev-2scryptodev-2s commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Explanation

This PR migrates TokenSearchDiscoveryController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates TokenSearchDiscoveryController to @metamask/messenger and renames metadata anonymous to includeInDebugSnapshot, with corresponding test, config, and docs updates.

  • @metamask/token-search-discovery-controller:
    • Migrate to new Messenger from @metamask/messenger; update controller messenger types and constructor wiring.
    • Switch imports to @metamask/base-controller/next.
    • Rename state metadata anonymousincludeInDebugSnapshot.
    • Add dependency @metamask/messenger and update tsconfig project references.
    • Update CHANGELOG with BREAKING changes.
  • Tests:
    • Replace restricted messenger helpers with new Messenger hierarchy; update metadata key usage.
  • Docs/Repo:
    • Update README dependency graph (add token_search_discovery_controller --> messenger, eip_7702_internal_rpc_middleware --> controller_utils).
    • Align yarn.lock with new dependency.

Written by Cursor Bugbot for commit f545217. This will update automatically on new commits. Configure here.

@cryptodev-2s
cryptodev-2s requested review from a team as code ownersSeptember 8, 2025 13:32
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/token-search-discovery-controller branch from e5c6e50 to 1d9486bCompareSeptember 8, 2025 13:33
@cryptodev-2scryptodev-2s self-assigned this Sep 8, 2025
@cryptodev-2scryptodev-2s mentioned this pull request Sep 8, 2025
43 tasks
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/token-search-discovery-controller branch from 1d9486b to 52b655cCompareSeptember 8, 2025 13:51
mcmire
mcmire previously approved these changes Sep 10, 2025
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/token-search-discovery-controller branch from 52b655c to e3a3622CompareSeptember 24, 2025 13:42
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/token-search-discovery-controller branch from e3a3622 to fa22b4aCompareOctober 7, 2025 08:57
mcmire
mcmire previously approved these changes Oct 7, 2025

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding
FrederikBolding added this pull request to the merge queueOct 27, 2025
auto-merge was automatically disabled October 27, 2025 11:43

Pull Request is not mergeable

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Oct 27, 2025
@FrederikBolding
FrederikBolding added this pull request to the merge queueOct 27, 2025
Merged via the queue into main with commit e7cc4c4Oct 27, 2025
256 of 257 checks passed
@FrederikBolding
FrederikBolding deleted the cryptodev-2s/messenger/token-search-discovery-controller branch October 27, 2025 12:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cryptodev-2s@mcmire@Mrtenz@FrederikBolding@mikesposito