Skip to content

refactor: migrate RemoteFeatureFlagController to @metamask/messenger - #6502

Merged
FrederikBolding merged 6 commits into
mainfrom
cryptodev-2s/messenger/remote-feature-flag-controller
Oct 27, 2025
Merged

refactor: migrate RemoteFeatureFlagController to @metamask/messenger#6502
FrederikBolding merged 6 commits into
mainfrom
cryptodev-2s/messenger/remote-feature-flag-controller

Conversation

@cryptodev-2s

@cryptodev-2scryptodev-2s commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Explanation

This PR migrates RemoteFeatureFlagController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates RemoteFeatureFlagController to the new @metamask/messenger, updates metadata and exports, adjusts tests and TS configs, and documents breaking changes.

  • Remote Feature Flag Controller:
    • Migrate from RestrictedMessenger (@metamask/base-controller) to Messenger (@metamask/messenger); update types and constructor to use new messenger.
    • Switch imports to @metamask/base-controller/next.
    • Rename metadata key anonymous to includeInDebugSnapshot (breaking); update tests accordingly.
    • Tidy exports: move RemoteFeatureFlagControllerState type to remote-feature-flag-controller; remove it from remote-feature-flag-controller-types; adjust index.ts exports.
    • Update tests to construct namespaced messengers via @metamask/messenger and new metadata key.
    • Add dependency @metamask/messenger@^0.3.0; update tsconfig references to include packages/messenger.
  • Docs/Repo:
    • Update README dependency graph to show remote_feature_flag_controller --> messenger and add eip_7702_internal_rpc_middleware --> controller_utils edge.
    • Update package changelog with breaking changes regarding messenger migration and metadata rename.
    • Refresh lockfile.

Written by Cursor Bugbot for commit ce27877. This will update automatically on new commits. Configure here.

@cryptodev-2s
cryptodev-2s requested review from a team as code ownersSeptember 9, 2025 10:01
@cryptodev-2scryptodev-2s self-assigned this Sep 9, 2025
@cryptodev-2scryptodev-2s changed the title refactor: migrate RemoteFeatureFlagController to @metamask/messengerrefactor: migrate RemoteFeatureFlagController to @metamask/messengerSep 9, 2025
@cryptodev-2scryptodev-2s mentioned this pull request Sep 9, 2025
43 tasks
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/remote-feature-flag-controller branch 2 times, most recently from 40ee512 to dd1859eCompareSeptember 9, 2025 10:25
mcmire
mcmire previously approved these changes Sep 10, 2025
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/remote-feature-flag-controller branch from dd1859e to eb1e428CompareSeptember 24, 2025 14:20
@cryptodev-2s
cryptodev-2s requested a review from a teamSeptember 24, 2025 14:21
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/remote-feature-flag-controller branch from eb1e428 to 779543dCompareOctober 7, 2025 09:05
mcmire
mcmire previously approved these changes Oct 7, 2025

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding
FrederikBolding added this pull request to the merge queueOct 27, 2025
auto-merge was automatically disabled October 27, 2025 11:36

Pull Request is not mergeable

@FrederikBolding
FrederikBolding removed this pull request from the merge queue due to a manual request Oct 27, 2025
@FrederikBolding
FrederikBolding added this pull request to the merge queueOct 27, 2025
Merged via the queue into main with commit d8bfe04Oct 27, 2025
256 of 257 checks passed
@FrederikBolding
FrederikBolding deleted the cryptodev-2s/messenger/remote-feature-flag-controller branch October 27, 2025 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cryptodev-2s@mcmire@Mrtenz@FrederikBolding@mikesposito