Skip to content

refactor: migrate PermissionLogController to @metamask/messenger - #6536

Merged
cryptodev-2s merged 6 commits into
mainfrom
cryptodev-2s/messenger/permission-log-controller
Oct 27, 2025
Merged

refactor: migrate PermissionLogController to @metamask/messenger#6536
cryptodev-2s merged 6 commits into
mainfrom
cryptodev-2s/messenger/permission-log-controller

Conversation

@cryptodev-2s

@cryptodev-2scryptodev-2s commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Explanation

This PR migrates PermissionLogController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates PermissionLogController to @metamask/messenger, updates types/metadata and exports, adapts tests, and updates configs/changelog.

  • PermissionLogController:
    • Migrate to @metamask/messengerMessenger; use @metamask/base-controller/next types (ControllerGetStateAction, ControllerStateChangeEvent).
    • Define and export PermissionLogControllerMessenger, PermissionLogControllerActions, PermissionLogControllerGetStateAction, PermissionLogControllerEvents, PermissionLogControllerStateChangeEvent.
    • Rename metadata anonymous to includeInDebugSnapshot.
    • Switch index to named exports and re-export new types.
  • Tests:
    • Update to construct root/child messengers from @metamask/messenger and use deriveStateFromMetadata from @metamask/base-controller/next.
  • Package/Config:
    • Add dependency @metamask/messenger@^0.3.0; add TS project references to packages/messenger.
    • Changelog: note BREAKING migration to new Messenger and metadata rename; document new exported types.
  • Docs:
    • README dependency graph: add permission_log_controller --> messenger; minor graph tweak for eip_7702_internal_rpc_middleware.

Written by Cursor Bugbot for commit 2c60018. This will update automatically on new commits. Configure here.

@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/permission-log-controller branch from b5ab756 to f9dc4ffCompareOctober 7, 2025 10:37
@cryptodev-2s
cryptodev-2s requested a review from a team as a code ownerOctober 7, 2025 10:37
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/permission-log-controller branch 2 times, most recently from a743253 to a16ceffCompareOctober 7, 2025 10:39
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/permission-log-controller branch from a16ceff to b36974eCompareOctober 7, 2025 10:50
mcmire
mcmire previously approved these changes Oct 7, 2025

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment threadpackages/permission-log-controller/src/index.ts
Comment threadpackages/permission-log-controller/CHANGELOG.md Outdated
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@cryptodev-2s
cryptodev-2s added this pull request to the merge queueOct 27, 2025
Merged via the queue into main with commit ce4c907Oct 27, 2025
256 of 257 checks passed
@cryptodev-2s
cryptodev-2s deleted the cryptodev-2s/messenger/permission-log-controller branch October 27, 2025 13:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cryptodev-2s@mcmire@FrederikBolding@Mrtenz@mikesposito