Uh oh!
There was an error while loading. Please reload this page.
refactor: migrate NetworkEnablementController to @metamask/messenger - #6540
Merged
FrederikBolding merged 7 commits intoOct 27, 2025
Merged
Conversation
43 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cryptodev-2sforce-pushed
the
cryptodev-2s/messenger/network-enablement-controller
branch
2 times, most recently
from
September 10, 2025 11:13
294d507 to
9130d1eCompare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cryptodev-2sforce-pushed
the
cryptodev-2s/messenger/network-enablement-controller
branch
from
September 10, 2025 11:28
9130d1e to
44f2265Comparemcmire
reviewed
Sep 10, 2025
Uh oh!
There was an error while loading. Please reload this page.
cryptodev-2sforce-pushed
the
cryptodev-2s/messenger/network-enablement-controller
branch
from
October 7, 2025 12:08
44f2265 to
c7b3883Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mcmire
requested changes
Oct 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
…r/network-enablement-controller
Mrtenz
approved these changes
Oct 27, 2025
Uh oh!
There was an error while loading. Please reload this page.
FrederikBolding
deleted the
cryptodev-2s/messenger/network-enablement-controller
branch
October 27, 2025 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
NetworkEnablementControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates
NetworkEnablementControllerto the new@metamask/messengerAPI, updates metadata and tests, and adds related package/config references.RestrictedMessenger(@metamask/base-controller) toMessenger(@metamask/messenger); update typeNetworkEnablementControllerMessengerand wiring.@metamask/base-controller/nextand replacemessagingSystem.callwithmessenger.call.anonymoustoincludeInDebugSnapshot.src/NetworkEnablementController.test.ts):Messengerinstances with delegation; publish viarootMessenger.messenger.call; remove old helper and adjust setups accordingly.@metamask/messengerdependency and TS project references; update README dependency graph to includemessengerand link fromnetwork_enablement_controller.Written by Cursor Bugbot for commit e8eff3b. This will update automatically on new commits. Configure here.