Uh oh!
There was an error while loading. Please reload this page.
refactor: migrate MultichainAccountService to @metamask/messenger - #6544
Merged
cryptodev-2s merged 17 commits intoOct 27, 2025
Conversation
43 tasks
cryptodev-2sforce-pushed
the
cryptodev-2s/messenger/multichain-account-service
branch
from
September 9, 2025 21:46
18f8701 to
2ea0719Comparecryptodev-2sforce-pushed
the
cryptodev-2s/messenger/multichain-account-service
branch
from
September 9, 2025 22:31
2ea0719 to
f22848cComparemcmire
previously approved these changes
Sep 10, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mikesposito
previously approved these changes
Oct 27, 2025
FrederikBolding
previously approved these changes
Oct 27, 2025
github-merge-queueBot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 27, 2025
…r/multichain-account-service
cryptodev-2s
dismissed stale reviews from FrederikBolding and mikesposito
via
October 27, 2025 12:58
b90d0cacryptodev-2s
enabled auto-merge
October 27, 2025 12:58
Uh oh!
There was an error while loading. Please reload this page.
FrederikBolding
approved these changes
Oct 27, 2025
auto-merge was automatically disabled
October 27, 2025 13:11
Pull Request is not mergeable
Uh oh!
There was an error while loading. Please reload this page.
cryptodev-2s
deleted the
cryptodev-2s/messenger/multichain-account-service
branch
October 27, 2025 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
MultichainAccountServiceto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrate
MultichainAccountServiceand tests from@metamask/base-controllermessenger to the new@metamask/messenger, updating types, helpers, configs, and dependencies.RestrictedMessengerfrom@metamask/base-controllerwith newMessengerfrom@metamask/messengerinsrc/types.tsand all usages.RootMessengertest helper and implement delegation-basedgetMultichainAccountServiceMessengerinsrc/tests/messenger.ts.rootMessengerforregisterActionHandler/publishand pass restricted messenger to providers/service.@metamask/messengertopackages/multichain-account-service/package.jsonand reference it intsconfig*.json.multichain_account_service --> messenger.@metamask/messengerand expects itsMessengertype.Written by Cursor Bugbot for commit b90d0ca. This will update automatically on new commits. Configure here.