Skip to content

refactor: migrate MultichainAccountService to @metamask/messenger - #6544

Merged
cryptodev-2s merged 17 commits into
mainfrom
cryptodev-2s/messenger/multichain-account-service
Oct 27, 2025
Merged

refactor: migrate MultichainAccountService to @metamask/messenger#6544
cryptodev-2s merged 17 commits into
mainfrom
cryptodev-2s/messenger/multichain-account-service

Conversation

@cryptodev-2s

@cryptodev-2scryptodev-2s commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Explanation

This PR migrates MultichainAccountService to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrate MultichainAccountService and tests from @metamask/base-controller messenger to the new @metamask/messenger, updating types, helpers, configs, and dependencies.

  • Multichain Account Service (BREAKING)
    • Replace RestrictedMessenger from @metamask/base-controller with new Messenger from @metamask/messenger in src/types.ts and all usages.
    • Add RootMessenger test helper and implement delegation-based getMultichainAccountServiceMessenger in src/tests/messenger.ts.
    • Update tests to use rootMessenger for registerActionHandler/publish and pass restricted messenger to providers/service.
  • Dependencies/Config
    • Add dependency @metamask/messenger to packages/multichain-account-service/package.json and reference it in tsconfig*.json.
    • Update README dependency graph to include multichain_account_service --> messenger.
  • Changelog
    • Document breaking change: service now uses @metamask/messenger and expects its Messenger type.

Written by Cursor Bugbot for commit b90d0ca. This will update automatically on new commits. Configure here.

@cryptodev-2scryptodev-2s self-assigned this Sep 9, 2025
@cryptodev-2s
cryptodev-2s requested review from a team as code ownersSeptember 9, 2025 21:20
@cryptodev-2scryptodev-2s mentioned this pull request Sep 9, 2025
43 tasks
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/multichain-account-service branch from 18f8701 to 2ea0719CompareSeptember 9, 2025 21:46
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/multichain-account-service branch from 2ea0719 to f22848cCompareSeptember 9, 2025 22:31
mcmire
mcmire previously approved these changes Sep 10, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

mikesposito
mikesposito previously approved these changes Oct 27, 2025
FrederikBolding
FrederikBolding previously approved these changes Oct 27, 2025
@FrederikBolding
FrederikBolding added this pull request to the merge queueOct 27, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to a conflict with the base branch Oct 27, 2025
@cryptodev-2s
cryptodev-2s added this pull request to the merge queueOct 27, 2025
auto-merge was automatically disabled October 27, 2025 13:11

Pull Request is not mergeable

Merged via the queue into main with commit b4c76edOct 27, 2025
253 checks passed
@cryptodev-2s
cryptodev-2s deleted the cryptodev-2s/messenger/multichain-account-service branch October 27, 2025 13:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cryptodev-2s@mcmire@FrederikBolding@mikesposito