Skip to content

refactor: migrate {AbstractMessage,DecryptMessage,EncryptionPublicKey}Manager to @metamask/messenger - #6545

Merged
FrederikBolding merged 11 commits into
mainfrom
cryptodev-2s/messenger/message-manager
Oct 27, 2025
Merged

refactor: migrate {AbstractMessage,DecryptMessage,EncryptionPublicKey}Manager to @metamask/messenger#6545
FrederikBolding merged 11 commits into
mainfrom
cryptodev-2s/messenger/message-manager

Conversation

@cryptodev-2s

@cryptodev-2scryptodev-2s commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Explanation

This PR migrates AbstractMessageManager, EncryptionPublicKeyManager and DecryptMessageManager to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates AbstractMessageManager, DecryptMessageManager, and EncryptionPublicKeyManager to the new @metamask/messenger API, updating types/events and wiring, and adds the messenger dependency.

  • Message Manager (breaking)
    • Switch from RestrictedMessenger (@metamask/base-controller) to Messenger (@metamask/messenger) across AbstractMessageManager, DecryptMessageManager, and EncryptionPublicKeyManager.
    • Update publish calls to use this.messenger.publish and rework action/event typings (ControllerGetStateAction, ControllerStateChangeEvent).
    • Adjust state metadata keys (anonymousincludeInDebugSnapshot).
  • Tests
    • Update mocks and types to use Messenger and new metadata flag.
  • Configs/Dependencies
    • Add @metamask/messenger dependency and TypeScript project references.
    • Update README dependency graph to show message_managermessenger and add new edge for eip-7702-internal-rpc-middleware.

Written by Cursor Bugbot for commit c9835ae. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/message-manager branch from ab6c5fa to 202b3b4CompareSeptember 10, 2025 11:38
@cryptodev-2s
cryptodev-2sforce-pushed the cryptodev-2s/messenger/message-manager branch from 202b3b4 to 3480c41CompareSeptember 10, 2025 14:05
Comment threadpackages/message-manager/src/index.ts Outdated
@mikesposito
mikesposito added this pull request to the merge queueOct 27, 2025
@FrederikBolding
FrederikBolding removed this pull request from the merge queue due to the queue being cleared Oct 27, 2025
@FrederikBolding
FrederikBolding added this pull request to the merge queueOct 27, 2025
Merged via the queue into main with commit ff928bcOct 27, 2025
256 of 257 checks passed
@FrederikBolding
FrederikBolding deleted the cryptodev-2s/messenger/message-manager branch October 27, 2025 11:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cryptodev-2s@mcmire@FrederikBolding@mikesposito