Skip to content

feat: allow partial revokes via wallet_revokeSession - #6668

Merged
ffmcgee725 merged 11 commits into
mainfrom
jc/WAPI-728
Sep 23, 2025
Merged

feat: allow partial revokes via wallet_revokeSession#6668
ffmcgee725 merged 11 commits into
mainfrom
jc/WAPI-728

Conversation

@ffmcgee725

Copy link
Copy Markdown
Member

Explanation

Uniswap reported a bug in slack here where MetaMask was unpermitting any EVM connections for a dapp if that dapp used the solana wallet standard provider to make a connect request and then cancelled it.

This call to disconnect() is happening outside of our packages and is not related to a previous but similar bug where our own wallet-standard provider was calling wallet_revokeSession when receiving an empty solana accountsChanged event.

To fix this, this PR proposes an implementation for partial permission revoking in the wallet_revokeSession handler so that we can then update our solana wallet-standard provider to only revoke the solana scopes when it is asked to disconnect.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Loading
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ffmcgee725@jiexi@adonesky1