Skip to content

feat: make getCryptoApproveTransactionParams synchronous - #6930

Merged
chaitanyapotti merged 4 commits into
mainfrom
feat/subscription-controller-getCryptoApproveTransactionParams-sync
Oct 24, 2025
Merged

feat: make getCryptoApproveTransactionParams synchronous#6930
chaitanyapotti merged 4 commits into
mainfrom
feat/subscription-controller-getCryptoApproveTransactionParams-sync

Conversation

@tuna1207

@tuna1207tuna1207 commented Oct 23, 2025

Copy link
Copy Markdown
Member

Explanation

  • Make getCryptoApproveTransactionParams synchronous

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Makes getCryptoApproveTransactionParams synchronous and updates tests and changelog accordingly.

  • Controller:
    • Change getCryptoApproveTransactionParams in src/SubscriptionController.ts from async to synchronous (remove async, return GetCryptoApproveTransactionResponse instead of Promise).
  • Tests:
    • Update SubscriptionController.test.ts to call getCryptoApproveTransactionParams synchronously and adjust error assertions.
  • Changelog:
    • Add entry noting the method is now synchronous in CHANGELOG.md under Unreleased.

Written by Cursor Bugbot for commit 778d4dc. This will update automatically on new commits. Configure here.

@tuna1207
tuna1207 marked this pull request as ready for review October 23, 2025 14:40
@tuna1207
tuna1207 requested review from a team as code ownersOctober 23, 2025 14:40
cursor[bot]

This comment was marked as outdated.

chaitanyapotti
chaitanyapotti previously approved these changes Oct 23, 2025
@chaitanyapotti
chaitanyapotti enabled auto-merge (squash) October 23, 2025 14:59
@chaitanyapotti
chaitanyapotti merged commit ccb493e into mainOct 24, 2025
448 of 503 checks passed
@chaitanyapotti
chaitanyapotti deleted the feat/subscription-controller-getCryptoApproveTransactionParams-sync branch October 24, 2025 04:45
Gudahtt added a commit that referenced this pull request Oct 24, 2025
…r/multichain-transactions-controller
* origin/main: (35 commits)
feat: `JsonRpcEngineV2` (#6176)
Release 641.0.0 (#6940)
feat: Add transaction emulation actions (#6935)
Release/640.0.0 (#6934)
fix(core-backend): control randomness to fix flaky test (#6936)
chore: Add `@metamask-previews/*` to NPM age gate exceptions (#6937)
Release/639.0.0 (#6931)
feat: make getCryptoApproveTransactionParams synchronous (#6930)
feat: add new actions to `KeyringController` (#6928)
feat: add `getAccounts` to `AccountsController` (#6927)
chore: remove `Monad Mainnet` single call balance contract and add into account v4 (#6929)
Release/638.0.0 (#6923)
fix: Downgrade `multiformats` to `^9.9.0` to avoid ESM-only dependency (#6920)
Release/637.0.0 (#6919)
feat(account-tree-controller): add callbacks for hidden and pinned data (#6910)
Release 636.0.0 (#6918)
fix(core-backend): reconnection logic (#6861)
fix: Tx state listener and signature coverage (#6906)
Release/635.0.0 (#6917)
fix(base-controller): add TypeScript declaration file for legacy module resolution (#6915)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-shieldTransaction Shieldteam-onboarding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tuna1207@chaitanyapotti