Uh oh!
There was an error while loading. Please reload this page.
refactor(transaction-controller): encapsulate provider logic - #8273
Merged
Conversation
matthewwalsh0force-pushed
the
feat/encapsulate-provider-util
branch
3 times, most recently
from
March 23, 2026 16:15
72ca7a5 to
a7e5332Comparematthewwalsh0
marked this pull request as ready for review
March 24, 2026 23:36
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
matthewwalsh0
commented
Mar 25, 2026
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
matthewwalsh0
commented
Mar 25, 2026
MemberAuthor
@metamaskbot publish-preview |
8 tasks
…ethQuery from transaction-controller Replace all ethQuery/EthQuery usage with a new rpcRequest() utility that accepts messenger + chainId/networkClientId + method + params. Any file can now send RPC requests without passing around ethQuery instances. - Add utils/provider.ts with rpcRequest() and getProvider() functions - Migrate all utils, gas-flows, helpers, hooks, and TransactionController - Update GasFeeFlowRequest type: ethQuery -> networkClientId (BREAKING) - Update determineTransactionType signature to options object (BREAKING) - Remove @metamask/eth-query dependency - Update all test files to match new signatures
…nts for connectivity-controller
matthewwalsh0force-pushed
the
feat/encapsulate-provider-util
branch
from
March 27, 2026 12:55
a0caca0 to
2fbeb5cCompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
OGPoyraz
previously approved these changes
Mar 27, 2026
vinistevam
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently,
transaction-controllerpassesethQueryinstances throughout the codebase — into utils, helpers, hooks, and gas flows — to make RPC calls. This couples every layer toEthQueryinternals and makes the provider plumbing verbose and fragile.This PR introduces a
utils/provider.tsmodule with functions includingrpcRequestandgetProvider, meaning allEthQueryusage is replaced, and all provider logic is encapsulated and callable anywhere with amessenger.References
Checklist
Note
Medium Risk
Medium risk because it replaces
EthQueryacross transaction publishing, gas estimation, and pending-tracking flows with a new messenger-based RPC abstraction, which could change runtime RPC behavior and error handling. Also includes a breaking API/export removal (determineTransactionType) and dependency removal (@metamask/eth-query).Overview
Refactors
transaction-controllerto remove@metamask/eth-queryentirely and route all RPC access through newutils/provider.tshelpers (getProvider,rpcRequest,getChainId,getNetworkClientId) using the messenger to resolve network clients.Updates transaction publishing, gas estimation/fee flows, simulation balance checks, batch/sequential publish hooks,
PendingTransactionTracker, and related helpers to passnetworkClientId/messengerinstead ofEthQuery/provider instances, and adjusts tests/integration mocks accordingly. Also removes the public export ofdetermineTransactionType(breaking change) and updates.gitignoreto ignore.sisyphus/.Written by Cursor Bugbot for commit 7c456b9. This will update automatically on new commits. Configure here.