Uh oh!
There was an error while loading. Please reload this page.
Release/1031.0.0 - #9078
Conversation
✅ Changelogs updated and pushed. |
GuillaumeRx
left a comment
There was a problem hiding this comment.
There's a breaking change under Removed, The release of assets-controllers should be a major (109.0.0)
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
01846ac to
d65a194CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
345fa67 to
9d084d5Compare| - Bump `@metamask/bridge-controller` from `^75.1.0` to `^75.1.1` ([#9078](https://github.com/MetaMask/core/pull/9078)) | ||
| - Bump `@metamask/bridge-controller` from `^75.0.0` to `^75.1.0` ([#9072](https://github.com/MetaMask/core/pull/9072)) |
There was a problem hiding this comment.
You mean using only one line like the following ?
- Bump
@metamask/bridge-controllerfrom^75.0.0to^75.1.1(#9078)
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> <!-- mms-check directive vocabulary — read by .github/scripts/shared/pr-template-checks.ts at module load to build the validation plan. Directives are invisible in rendered markdown and must NOT be removed or edited without updating the validator registry. type=text Section must contain non-placeholder prose. type=changelog Section must have a valid CHANGELOG entry: line. type=issue-link Section must have a Fixes:/Closes:/Refs: line with a value. type=manual-testing Section must have real testing steps or an explicit N/A. type=screenshot Section must have evidence (image/URL) or an explicit N/A. type=checklist Section must have all checkboxes consciously checked. required=true|false Whether a missing/invalid section blocks the PR check. Sections without a directive are checked for structural presence only. --> ## **Description** <!-- mms-check: type=text required=true --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> - Bump of `@metamask/assets-controllers` dependency from `^108.4.0` to `^109.0.0` after new [core release](MetaMask/core#9078) - Removed `TransactionController:incomingTransactionsReceived` from `TokenBalancesController` since described as breaking change in the [`@metamask/assets-controllers` CHANGELOG](https://github.com/MetaMask/core/pull/9078/changes#diff-2f986b0c95bbc85106e03a1488e264023e3c500a078db85033a92e7b4da66f2fR10) ## **Changelog** <!-- mms-check: type=changelog required=true --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Bump `@metamask/assets-controllers` from 108.4.0 to 109.0.0 ## **Related issues** <!-- mms-check: type=issue-link required=true --> Fixes: add support for assets detection on Arc network ## **Manual testing steps** <!-- mms-check: type=manual-testing required=true --> 1. Import SRP 2. Import private key funds account with Arc funds 3. Click on tokens 4. Add Arc network 5. Go to homepage tokens, verify the USDC on Arc network is displayed 6. Send USDC from imported account to account (with no funds) 7. Verify send transaction is confirmed 8. Go to other Account and verify the sent funds are listed on Tokens page ## **Screenshots/Recordings** <!-- mms-check: type=screenshot required=true --> <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> N/A ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- mms-check: type=checklist required=true --> <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [X] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Token balance refresh timing after incoming transfers may differ because TokenBalancesController no longer reacts to incomingTransactionsReceived; verify Arc/USDC detection and post-receive balances in manual testing. > > **Overview** > Upgrades **`@metamask/assets-controllers`** from **108.4.0** to **109.0.0** (lockfile included) to pick up the latest core release, including **Arc network** asset detection support referenced in the ticket. > > Aligns with a **breaking change** in v109: **`TokenBalancesController`** no longer subscribes to **`TransactionController:incomingTransactionsReceived`**, so that event is removed from the token-balances controller messenger allowlist in **`token-balances-controller-messenger.ts`**. Incoming-tx notifications elsewhere (e.g. **`Engine`** → **`NotificationManager`**) are unchanged in this diff. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 915a6e7. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> <!-- mms-check directive vocabulary — read by .github/scripts/shared/pr-template-checks.ts at module load to build the validation plan. Directives are invisible in rendered markdown and must NOT be removed or edited without updating the validator registry. type=text Section must contain non-placeholder prose. type=changelog Section must have a valid CHANGELOG entry: line. type=issue-link Section must have a Fixes:/Closes:/Refs: line with a value. type=manual-testing Section must have real testing steps or an explicit N/A. type=screenshot Section must have evidence (image/URL) or an explicit N/A. type=checklist Section must have all checkboxes consciously checked. required=true|false Whether a missing/invalid section blocks the PR check. Sections without a directive are checked for structural presence only. --> ## **Description** <!-- mms-check: type=text required=true --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> - Bump of `@metamask/assets-controllers` dependency from `^108.4.0` to `^109.0.0` after new [core release](MetaMask/core#9078) - Removed `TransactionController:incomingTransactionsReceived` from `TokenBalancesController` since described as breaking change in the [`@metamask/assets-controllers` CHANGELOG](https://github.com/MetaMask/core/pull/9078/changes#diff-2f986b0c95bbc85106e03a1488e264023e3c500a078db85033a92e7b4da66f2fR10) ## **Changelog** <!-- mms-check: type=changelog required=true --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Bump `@metamask/assets-controllers` from 108.4.0 to 109.0.0 ## **Related issues** <!-- mms-check: type=issue-link required=true --> Fixes: add support for assets detection on Arc network ## **Manual testing steps** <!-- mms-check: type=manual-testing required=true --> 1. Import SRP 2. Import private key funds account with Arc funds 3. Click on tokens 4. Add Arc network 5. Go to homepage tokens, verify the USDC on Arc network is displayed 6. Send USDC from imported account to account (with no funds) 7. Verify send transaction is confirmed 8. Go to other Account and verify the sent funds are listed on Tokens page ## **Screenshots/Recordings** <!-- mms-check: type=screenshot required=true --> <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> N/A ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- mms-check: type=checklist required=true --> <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [X] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Token balance refresh timing after incoming transfers may differ because TokenBalancesController no longer reacts to incomingTransactionsReceived; verify Arc/USDC detection and post-receive balances in manual testing. > > **Overview** > Upgrades **`@metamask/assets-controllers`** from **108.4.0** to **109.0.0** (lockfile included) to pick up the latest core release, including **Arc network** asset detection support referenced in the ticket. > > Aligns with a **breaking change** in v109: **`TokenBalancesController`** no longer subscribes to **`TransactionController:incomingTransactionsReceived`**, so that event is removed from the token-balances controller messenger allowlist in **`token-balances-controller-messenger.ts`**. Incoming-tx notifications elsewhere (e.g. **`Engine`** → **`NotificationManager`**) are unchanged in this diff. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 915a6e7. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
…43422) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> - Bump of `@metamask/assets-controllers` dependency from `^108.5.0` to `^109.0.0` after new [core release](MetaMask/core#9078) - Removed `TransactionController:incomingTransactionsReceived` from `TokenBalancesController` since described as breaking change in the [`@metamask/assets-controllers` CHANGELOG](https://github.com/MetaMask/core/pull/9078/changes#diff-2f986b0c95bbc85106e03a1488e264023e3c500a078db85033a92e7b4da66f2fR10) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Bump `@metamask/assets-controllers` from 108.5.0 to 109.0.0 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Token balance updates may no longer react to incoming transactions via TokenBalancesController; verify balance refresh still behaves correctly after the assets-controllers breaking change. > > **Overview** > Bumps **`@metamask/assets-controllers`** from **108.5.0** to **109.0.0** (with lockfile updates, including **`@metamask/transaction-controller` 67.1.0**) and records the change in **CHANGELOG**. > > Aligns the extension with upstream breaking changes by **removing** `TransactionController:incomingTransactionsReceived` from the **TokenBalancesController** messenger allowlist in `token-balances-controller-messenger.ts`, so token balance refresh is no longer wired to that transaction event here. > > Regenerates **LavaMoat** browserify/webpack policies for the new dependency graph (e.g. nested `@metamask/assets-controller>@metamask/assets-controllers`, updated **TanStack query-core** package paths, and simplified **keyring-controller** references for transaction-pay). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e8cc21a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
…ask#43422) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> - Bump of `@metamask/assets-controllers` dependency from `^108.5.0` to `^109.0.0` after new [core release](MetaMask/core#9078) - Removed `TransactionController:incomingTransactionsReceived` from `TokenBalancesController` since described as breaking change in the [`@metamask/assets-controllers` CHANGELOG](https://github.com/MetaMask/core/pull/9078/changes#diff-2f986b0c95bbc85106e03a1488e264023e3c500a078db85033a92e7b4da66f2fR10) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Bump `@metamask/assets-controllers` from 108.5.0 to 109.0.0 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Token balance updates may no longer react to incoming transactions via TokenBalancesController; verify balance refresh still behaves correctly after the assets-controllers breaking change. > > **Overview** > Bumps **`@metamask/assets-controllers`** from **108.5.0** to **109.0.0** (with lockfile updates, including **`@metamask/transaction-controller` 67.1.0**) and records the change in **CHANGELOG**. > > Aligns the extension with upstream breaking changes by **removing** `TransactionController:incomingTransactionsReceived` from the **TokenBalancesController** messenger allowlist in `token-balances-controller-messenger.ts`, so token balance refresh is no longer wired to that transaction event here. > > Regenerates **LavaMoat** browserify/webpack policies for the new dependency graph (e.g. nested `@metamask/assets-controller>@metamask/assets-controllers`, updated **TanStack query-core** package paths, and simplified **keyring-controller** references for transaction-pay). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e8cc21a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> - Bump of `@metamask/assets-controllers` dependency from `^108.5.0` to `^109.0.0` after new [core release](MetaMask/core#9078) - Removed `TransactionController:incomingTransactionsReceived` from `TokenBalancesController` since described as breaking change in the [`@metamask/assets-controllers` CHANGELOG](https://github.com/MetaMask/core/pull/9078/changes#diff-2f986b0c95bbc85106e03a1488e264023e3c500a078db85033a92e7b4da66f2fR10) <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Bump `@metamask/assets-controllers` from 108.5.0 to 109.0.0 Fixes: 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Token balance updates may no longer react to incoming transactions via TokenBalancesController; verify balance refresh still behaves correctly after the assets-controllers breaking change. > > **Overview** > Bumps **`@metamask/assets-controllers`** from **108.5.0** to **109.0.0** (with lockfile updates, including **`@metamask/transaction-controller` 67.1.0**) and records the change in **CHANGELOG**. > > Aligns the extension with upstream breaking changes by **removing** `TransactionController:incomingTransactionsReceived` from the **TokenBalancesController** messenger allowlist in `token-balances-controller-messenger.ts`, so token balance refresh is no longer wired to that transaction event here. > > Regenerates **LavaMoat** browserify/webpack policies for the new dependency graph (e.g. nested `@metamask/assets-controller>@metamask/assets-controllers`, updated **TanStack query-core** package paths, and simplified **keyring-controller** references for transaction-pay). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e8cc21a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
… to 109.0.0 (#43504) - chore: bump @metamask/assets-controllers to 109.0.0 cp-13.36.0 (#43422) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> - Bump of `@metamask/assets-controllers` dependency from `^108.5.0` to `^109.0.0` after new [core release](MetaMask/core#9078) - Removed `TransactionController:incomingTransactionsReceived` from `TokenBalancesController` since described as breaking change in the [`@metamask/assets-controllers` CHANGELOG](https://github.com/MetaMask/core/pull/9078/changes#diff-2f986b0c95bbc85106e03a1488e264023e3c500a078db85033a92e7b4da66f2fR10) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Bump `@metamask/assets-controllers` from 108.5.0 to 109.0.0 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Token balance updates may no longer react to incoming transactions via TokenBalancesController; verify balance refresh still behaves correctly after the assets-controllers breaking change. > > **Overview** > Bumps **`@metamask/assets-controllers`** from **108.5.0** to **109.0.0** (with lockfile updates, including **`@metamask/transaction-controller` 67.1.0**) and records the change in **CHANGELOG**. > > Aligns the extension with upstream breaking changes by **removing** `TransactionController:incomingTransactionsReceived` from the **TokenBalancesController** messenger allowlist in `token-balances-controller-messenger.ts`, so token balance refresh is no longer wired to that transaction event here. > > Regenerates **LavaMoat** browserify/webpack policies for the new dependency graph (e.g. nested `@metamask/assets-controller>@metamask/assets-controllers`, updated **TanStack query-core** package paths, and simplified **keyring-controller** references for transaction-pay). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e8cc21a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> [aeb7d21](aeb7d21) --------- Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: gabrieledm <gabriele.delmonte@proton.me>
Explanation
Release
@metamask/assets-controllersReferences
Checklist
Note
Medium Risk
Mostly version/changelog churn, but the released assets-controller major carries breaking API and event-subscription changes that client integrators must adopt when they bump dependencies.
Overview
Monorepo release 1031.0.0 that cuts and wires up new package versions for the assets stack.
@metamask/assets-controllers109.0.0 (changelog: ARC token-detection / Accounts API support).@metamask/assets-controller9.0.0 is bumped to depend on it; downstreambridge-controller75.1.1,bridge-status-controller, andtransaction-pay-controller23.5.1 pick up the new assets packages. Updates are limited topackage.json,CHANGELOG.md, rootpackage.json, andyarn.lock—no application source in this diff.Consumers upgrading
@metamask/assets-controller@9inherit breaking changes already documented in that release: data-source options switch fromisNativeAssettogetAssetType,TransactionController:incomingTransactionsReceivedis no longer subscribed for balance refresh, and token detection behavior is gated on/v2/supportedNetworkswith softer failure handling.Reviewed by Cursor Bugbot for commit 8b3a382. Bugbot is set up for automated code reviews on this repo. Configure here.