Uh oh!
There was an error while loading. Please reload this page.
Fix check-release to ignore reversions to 0.0.0 - #9437
Merged
Conversation
Sometimes we set the version of a package prematurely and need to revert it to 0.0.0. Currently, the `check-release` would flag this as a problem: it would think that the package was being staged for release and and would require the `package.json` to also be bumped. In reality, however, this step should not be necessary, as packages with a version of 0.0.0 will not be released anyway.
cryptodev-2s
approved these changes
Jul 8, 2026
mcmire
marked this pull request as ready for review
July 8, 2026 22:01
mcmire
enabled auto-merge
July 8, 2026 22:04
Uh oh!
There was an error while loading. Please reload this page.
cryptodev-2s pushed a commit
that referenced
this pull request
Jul 8, 2026
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> Sometimes we set the version of a package prematurely and need to revert it to 0.0.0. Currently, the `check-release` action would flag this as a problem: it would think that the package was being staged for release and and would require the `package.json` to also be bumped. In reality, however, this step should not be necessary, as packages with a version of 0.0.0 will not be released anyway. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Single-line CI guard change with no runtime impact; only nuance is mixed PRs with real bumps still require root bump as before. > > **Overview** > Updates the **check-release** composite action so reverting a workspace package to **`0.0.0`** no longer counts as a version bump for the root `package.json` gate. > > The workspace scan now treats a change as a bump only when the new version differs from the merge-base version **and** the new version is not **`0.0.0`**, so PRs that undo a premature version without shipping a release are not forced to bump the root `package.json`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1ff9b0f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Sometimes we set the version of a package prematurely and need to revert it to 0.0.0. Currently, the
check-releaseaction would flag this as a problem: it would think that the package was being staged for release and and would require thepackage.jsonto also be bumped. In reality, however, this step should not be necessary, as packages with a version of 0.0.0 will not be released anyway.References
Checklist
Note
Low Risk
Single-line CI guard change with no runtime impact; only nuance is mixed PRs with real bumps still require root bump as before.
Overview
Updates the check-release composite action so reverting a workspace package to
0.0.0no longer counts as a version bump for the rootpackage.jsongate.The workspace scan now treats a change as a bump only when the new version differs from the merge-base version and the new version is not
0.0.0, so PRs that undo a premature version without shipping a release are not forced to bump the rootpackage.json.Reviewed by Cursor Bugbot for commit 1ff9b0f. Bugbot is set up for automated code reviews on this repo. Configure here.