Skip to content

fix: don't treat a 0.0.0 target version as a release in check-release - #9438

Closed
cryptodev-2s wants to merge 1 commit into
mainfrom
fix/check-release-ignore-zero-version
Closed

fix: don't treat a 0.0.0 target version as a release in check-release#9438
cryptodev-2s wants to merge 1 commit into
mainfrom
fix/check-release-ignore-zero-version

Conversation

@cryptodev-2s

@cryptodev-2scryptodev-2s commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Explanation

The check-release action flags any package whose version changed as a release, and then requires the root package.json to be bumped too. That breaks when you correct a package's version back down to 0.0.0, which is the unreleased initial state, not a real release.

This makes both loops in the action skip a package when its target version is 0.0.0, so resetting a version to 0.0.0 no longer trips the release check.

This should merge first, then #9436 (which resets @metamask/network-connection-banner-controller from 0.1.0 back to 0.0.0) will pass CI.

References

Unblocks #9436, follow up to #9041

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for cross repository changes as appropriate

Note

Low Risk
CI-only change to release validation logic; no runtime application or security paths affected.

Overview
The check-release composite action no longer treats a workspace package whose target version is 0.0.0 as a version bump or a release.

Both package-scan loops now continue when the head/new version is 0.0.0, so resetting a package from a published version back to the unreleased placeholder does not force a root package.json bump or include that package in release-conflict detection.

Reviewed by Cursor Bugbot for commit 6b24824. Bugbot is set up for automated code reviews on this repo. Configure here.

A target version of 0.0.0 is the unreleased initial state, so correcting a
package back to 0.0.0 shouldn't be flagged as a release or require a root
package.json bump.
@cryptodev-2s
cryptodev-2s requested a review from a team as a code ownerJuly 8, 2026 21:54
@cryptodev-2scryptodev-2s self-assigned this Jul 8, 2026
@cryptodev-2s
cryptodev-2s requested a review from mcmireJuly 8, 2026 21:54
@cryptodev-2s

cryptodev-2s commented Jul 8, 2026

Copy link
Copy Markdown
ContributorAuthor

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@cryptodev-2s