Uh oh!
There was an error while loading. Please reload this page.
fix: don't treat a 0.0.0 target version as a release in check-release - #9438
Closed
cryptodev-2s wants to merge 1 commit into
Closed
fix: don't treat a 0.0.0 target version as a release in check-release#9438cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
A target version of 0.0.0 is the unreleased initial state, so correcting a package back to 0.0.0 shouldn't be flagged as a release or require a root package.json bump.
cryptodev-2stemporarily deployed
to
default-branch
July 8, 2026 21:54 — with
GitHub Actions
Inactive
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
check-releaseaction flags any package whose version changed as a release, and then requires the rootpackage.jsonto be bumped too. That breaks when you correct a package's version back down to0.0.0, which is the unreleased initial state, not a real release.This makes both loops in the action skip a package when its target version is
0.0.0, so resetting a version to0.0.0no longer trips the release check.This should merge first, then #9436 (which resets
@metamask/network-connection-banner-controllerfrom0.1.0back to0.0.0) will pass CI.References
Unblocks #9436, follow up to #9041
Checklist
Note
Low Risk
CI-only change to release validation logic; no runtime application or security paths affected.
Overview
The
check-releasecomposite action no longer treats a workspace package whose target version is0.0.0as a version bump or a release.Both package-scan loops now
continuewhen the head/new version is0.0.0, so resetting a package from a published version back to the unreleased placeholder does not force a rootpackage.jsonbump or include that package in release-conflict detection.Reviewed by Cursor Bugbot for commit 6b24824. Bugbot is set up for automated code reviews on this repo. Configure here.