Uh oh!
There was an error while loading. Please reload this page.
feat(transaction-pay-controller): enable relay validation per transaction type - #9888
Merged
Merged
Conversation
matthewwalsh0
marked this pull request as ready for review
August 15, 2026 07:04
matthewwalsh0temporarily deployed
to
default-branch
August 15, 2026 07:04 — with
GitHub Actions
Inactive
jpuri
previously approved these changes
Aug 17, 2026
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Aug 19, 2026
Uh oh!
There was an error while loading. Please reload this page.
… default field Drop boolean support for the payStrategies.relay.validationEnabled flag; it is now object-only with an optional `default` toggle (omitted = false) plus per-TransactionType overrides. BREAKING CHANGE: validationEnabled is no longer a boolean.
…es via hasTransactionType Pass the full transaction to isRelayValidationEnabled and iterate over each transactionTypes entry, using hasTransactionType so a per-type override matches the top-level or any nested transaction type.
matthewwalsh0force-pushed
the
feat/validation-enabled-per-tx-type
branch
from
August 19, 2026 13:28
c87b3be to
9082f35Comparematthewwalsh0
enabled auto-merge
August 19, 2026 14:16
jpuri
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
payStrategies.relay.validationEnabledflag (in theconfirmations_pay_extendedremote feature flag) was a plain boolean, so Relay quote validation could only be toggled globally — there was no way to enable or disable it per transaction type.This PR replaces the boolean with an object-only schema:
defaultis the base toggle applied to every transaction type. When omitted, validation is off.transactionTypes[txType]entry overridesdefaultfor that specific type (using??, so an explicitfalseoverride correctly beats atruedefault).Because the
confirmations_pay_extendedflag is versioned, the boolean form is dropped rather than kept for backwards compatibility — this is a breaking change to the flag shape (trueis now expressed as{ default: true }).The resolver
isRelayValidationEnabledgains an optionaltransactionTypeparameter, and the single call site inrelay-validation.tspassesrequest.transaction.type. A newRelayValidationEnabledConfigtype describes the flag shape.References
Checklist
Note
Medium Risk
Breaking remote flag shape requires LaunchDarkly/client updates; behavior only affects whether Relay quotes are simulated, but misconfiguration could disable validation broadly or for specific types.
Overview
Breaking change:
confirmations_pay_extended.payStrategies.relay.validationEnabledis no longer a boolean. It must be{ default?: boolean; transactionTypes?: Partial<Record<TransactionType, boolean>> }(e.g.{ default: true }instead oftrue).isRelayValidationEnablednow takes an optionalTransactionMetaand resolves the toggle fromdefault, with per-TransactionTypeentries intransactionTypesoverriding when the top-level or nested transaction type matches (hasTransactionType).validateRelayQuotespassesrequest.transactioninto that check so simulation can be turned on or off per flow without a global flag flip.Tests and the changelog document the new shape and override behavior.
Reviewed by Cursor Bugbot for commit 9082f35. Bugbot is set up for automated code reviews on this repo. Configure here.