Uh oh!
There was an error while loading. Please reload this page.
refactor!: drop profile-sync-controller dependency - #9918
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b402180. Configure here.
| DEV = 'dev', | ||
| UAT = 'uat', | ||
| PRD = 'prod', | ||
| } |
There was a problem hiding this comment.
PRD env value mismatches predecessor
Medium Severity
ConfigRegistryApiEnv.PRD is 'prod', but the SDK.Env.PRD value it replaces is 'prd'. getConfigRegistryUrl treats anything other than 'prod' as a hostname prefix, so passing the previous production value builds client-config.prd-api... instead of the production host. Dev and UAT still match, so this only breaks production.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b402180. Configure here.
There was a problem hiding this comment.
it doesn't matter, since getConfigRegistryUrl matches the value against ConfigRegistryApiEnv.PRD, and in that case the env prefix will be simply omitted:
functiongetConfigRegistryUrl(env: ConfigRegistryApiEnv): string{constenvPrefix=env===ConfigRegistryApiEnv.PRD ? '' : `${env}-`;return`https://client-config.${envPrefix}api.cx.metamask.io/v1${ENDPOINT_PATH}`;}Uh oh!
There was an error while loading. Please reload this page.


Explanation
The
@metamask/config-registry-controllerdependency over@metamask/profile-sync-controlleris being dropped, by adding a newConfigRegistryApiEnvenum toconfig-registry-controllerpackage.The new enum can be used to select the API environment the service should use.
References
Checklist
Note
Cursor Bugbot is generating a summary for commit bd18275. Configure here.