Uh oh!
There was an error while loading. Please reload this page.
feat: add config-registry-{controller, api-service} to wallet - #9928
Merged
Conversation
mikespositoforce-pushed
the
me/feat/config-registry-to-wallet
branch
from
August 20, 2026 18:08
c1299a1 to
ff59021Comparemikesposito
enabled auto-merge
August 20, 2026 18:13
mcmire
reviewed
Aug 20, 2026
| init: ({ messenger, options }) => | ||
| new ConfigRegistryApiService({ | ||
| messenger, | ||
| env: options.env ?? ConfigRegistryApiEnv.PRD, |
Collaborator
There was a problem hiding this comment.
Is it intentional to always hit prod, even locally? Why not require clients to pass this in instead of having the Wallet Library default this?
MemberAuthor
There was a problem hiding this comment.
The idea was to preserve the optionality, but we can make it a mandatory option
mcmire
reviewed
Aug 20, 2026
| ): WalletOptions['instanceOptions'] { | ||
| return { | ||
| configRegistryApiService: { | ||
| env: ConfigRegistryApiEnv.PRD, |
Collaborator
There was a problem hiding this comment.
I don't know if I like this either, but at least it's consistent with the defaults wallet-cli uses for other controllers/services (i.e. it uses prod for other APIs).
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adding
@metamask/config-registry-controllerto thewalletpackage.References
Checklist
Note
Medium Risk
Breaking constructor API plus new remote config fetch on wallet startup. Duplicate messenger registration can fail existing consumers that already wire these controllers.
Overview
BREAKING: Default wallet init now constructs
ConfigRegistryApiServiceandConfigRegistryController, so remote config registry is part of the core wallet graph.instanceOptions.configRegistryApiServiceis required (env, optionalfetch/policyOptions).configRegistryControlleris optional (pollingInterval,fallbackConfig). The controller messenger delegates keyring, remote feature flags, andConfigRegistryApiService:fetchConfig.Consumers that already register these on a custom root messenger must drop their own wiring or registrations will collide.
wallet-clipassesConfigRegistryApiEnv.PRD.Reviewed by Cursor Bugbot for commit 4777e53. Bugbot is set up for automated code reviews on this repo. Configure here.