Uh oh!
There was an error while loading. Please reload this page.
Drop support for old Nodes - #17
Merged
Merged
Conversation
mcmireforce-pushed
the
upgrade-node
branch
3 times, most recently
from
November 26, 2024 23:24
0b17736 to
a11105bCompareNode 18 is the earliest version that we support across our ecosystem, and anything earlier is EOL, so it doesn't make sense to continue to support it. Using old Nodes is also preventing us from upgrading dependencies to address security vulnerabilities. Also update the lint-build-test GitHub workflow by running `npm ci` instead of just `npm i`. This ensures that the lockfile is not updated, which is not the case with just `npm i`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 18 is the earliest version that we support across our ecosystem, and anything earlier is EOL, so it doesn't make sense to continue to support it. Using old Nodes is also preventing us from upgrading dependencies to address security vulnerabilities.
Also update the lint-build-test GitHub workflow by running
npm ciinstead of justnpm i. This ensures that the lockfile is not updated, which is not the case with justnpm i.This PR is a prerequisite for doing any other work on this repo, as I cannot install Nodes older than 12 on my machine (and I do not want to use Docker).