build diff

[brad-decker]

ethjs-query

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

• You have followed our contributing guidelines
• Pull request has tests (we are going for 100% coverage!)
• Code is well-commented, linted and follows project conventions
• Documentation is updated (if necessary)
• Internal code generators and templates are updated (if necessary)
• Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

[brad-decker]

@legobeat could you investigate this when you get a chance?

[brad-decker]

[legobeat]

@brad-decker

• I am not sure why you're getting changes in the lockfile - I can not reproduce it from an npm i even when pinning to 6.13.4. OtoH, comparing before/after they both match the same versions in the end so it actually shouldn't make a difference in any case.
  • Fine to leave lockfile as-is or can we repro?
• on the source-map, looks like leftover that should have been committed earlier so yes, let's get that in.

[pedronfigueiredo]

I also get diffs on the package-lock.json when I use the versions you indicated above Brad.

[brad-decker]

@legobeat i think it may be Operating system differences in how npm is resolving packages at this version of npm? https://stackoverflow.com/questions/45335169/why-do-i-get-vastly-different-package-lock-json-files-when-i-run-npm-install -- i can remove the package-lock changes but I cannot build the package to publish without them.