Skip to content

devDeps: replace istanbul with nyc - #30

Draft
legobeat wants to merge 3 commits into
MetaMask:mainfrom
legobeat:devdeps-nyc
Draft

devDeps: replace istanbul with nyc#30
legobeat wants to merge 3 commits into
MetaMask:mainfrom
legobeat:devdeps-nyc

Conversation

@legobeat

@legobeatlegobeat commented Apr 26, 2024

Copy link
Copy Markdown

Replaces test-coverage library istanbul with nyc.

Addresses a few security advisories.

Based on

@legobeatlegobeat added the dependencies Pull requests that update a dependency file label Apr 26, 2024
@socket-security

socket-securityBot commented Apr 26, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/mocha@8.4.0environment, eval, filesystem Transitive: shell+746.12 MBjuergba
npm/nyc@15.1.0environment, filesystem, unsafe Transitive: eval, shell+963.54 MBcoreyfarrell

🚮 Removed packages:npm/istanbul@0.4.5, npm/mocha@7.2.0

View full report↗︎

@socket-security

socket-securityBot commented Apr 26, 2024

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/foreground-child@2.0.0, npm/istanbul-lib-report@3.0.1, npm/istanbul-lib-source-maps@4.0.1, npm/package-hash@4.0.0, npm/process-on-spawn@1.0.0, npm/spawn-wrap@2.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/package-hash@4.0.0
    @SocketSecurity ignore npm/process-on-spawn@1.0.0
    @SocketSecurity ignore npm/spawn-wrap@2.0.0
    

    shell access ok

    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/istanbul-lib-report@3.0.1
    @SocketSecurity ignore npm/istanbul-lib-source-maps@4.0.1
    @SocketSecurity ignore npm/foreground-child@2.0.0
    

    new authors ok

    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    dependenciesPull requests that update a dependency file

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @legobeat