1.18.0

[github-actions]

This is the release candidate for version 1.18.0.

[mcmire]

Looking at this PR, does the update-release-changelog action now expect projects to have a yarn update-changelog script? If so should we recreate this release PR, mark this as breaking here, and bump the version to 2.0.0?

[HowardBraham]

Oh, yes it does, hmm. I did look at this before, and there are only two consumers of update-release-changelog, which are metamask-extension and metamask-mobile:

https://github.com/search?q=org%3AMetaMask+update-release-changelog&type=code

I am hesitant to go to a new major version of github-tools. I guess if we want to make this backwards compatible, we can.

[mcmire]

Yeah, maybe we can still update to auto-changelog 6.2.0 but keep calling yarn auto-changelog update with all of the options we were passing before?

[HowardBraham]

Like this? And should I do this in the release PR, or create another separate PR?

if yarn run --silent update-changelog --help >/dev/null 2>&1; then
yarn update-changelog \
--repo "${GITHUB_REPOSITORY_URL}" \
--currentVersion "${VERSION}"
else
yarn auto-changelog update --rc \
--repo "${GITHUB_REPOSITORY_URL}" \
--currentVersion "${VERSION}" \
--autoCategorize \
--useChangelogEntry \
--useShortPrLink \
--requirePrNumbers
fi

[mcmire]

Ah yeah that would probably work too.

I would recommend making this change in a separate PR to keep the release PR just focused on bumping the version and updating the changelog.

[mcmire]

LGTM.