Uh oh!
There was an error while loading. Please reload this page.
ci: log number of merged PRs into main - #83
Conversation
There was a problem hiding this comment.
Bug: Bash Arithmetic Error with Null Values
The workflow fails with a bash arithmetic error when attempting to increment the success count for an existing date entry. This occurs because the jq expression, which retrieves the current success count from the spreadsheet, returns the string "null" if the corresponding cell in column C is empty or contains non-numeric data. Bash's arithmetic expansion cannot process the string "null", leading to a syntax error. The script should default the count to 0 if it's "null" before performing the increment.
.github/workflows/log-merge-group-success.yml#L42-L47
github-tools/.github/workflows/log-merge-group-success.yml
Lines 42 to 47 in 4db842b
Was this report helpful? Give feedback by reacting with 👍 or 👎
This PR creates a re-usable workflow which logs the number of PRs that get merged to main. The end goal of this is to extend our metrics, to better understand ci health, by getting the success merge rate, using both these data, and the number of PRs that get kicked out from the merge queue.
This PR is based on the work from @itsyoboieltr (see here)
Some notes:
Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes:
Are there any issues or other links reviewers should consult to understand this pull request better? For instance:
-->