Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

devDeps: update @metamask/eslint-config* from 11 to 12 - #165

Closed
legobeat wants to merge 6 commits into
MetaMask:mainfrom
legobeat:devdeps-eslint
Closed

devDeps: update @metamask/eslint-config* from 11 to 12#165
legobeat wants to merge 6 commits into
MetaMask:mainfrom
legobeat:devdeps-eslint

Conversation

@legobeat

@legobeatlegobeat commented Aug 31, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@legobeatlegobeat added the dependencies Pull requests that update a dependency file label Aug 31, 2023
@socket-security

socket-securityBot commented Aug 31, 2023

Copy link
Copy Markdown

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
eslint-plugin-promise6.1.1None+067.1 kBeslint-community-bot
eslint-plugin-n15.7.0filesystem+4883 kBweiran.zsd
@metamask/eslint-config-jest11.1.0...12.1.0None+2/-1195 kBmetamaskbot
@metamask/eslint-config-typescript11.1.0...12.1.0None+2/-1204 kBmetamaskbot
@metamask/eslint-config-nodejs11.1.0...12.1.0None+7/-31.16 MBmetamaskbot
@metamask/eslint-config11.1.0...12.1.0None+1/-0186 kBmetamaskbot

🚮 Removed packages:eslint-plugin-node@11.1.0

@socket-security

socket-securityBot commented Aug 31, 2023•
edited
Loading

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat

legobeat commented Aug 31, 2023

Copy link
Copy Markdown
ContributorAuthor
@SocketSecurity ignore eslint-plugin-n@15.7.0

fs access ok

@legobeat

legobeat commented Aug 31, 2023

Copy link
Copy Markdown
ContributorAuthor
@SocketSecurity ignore builtins@5.0.1

maintainership ok

@legobeat
legobeat marked this pull request as ready for review August 31, 2023 20:30
@legobeat
legobeat requested a review from a team as a code ownerAugust 31, 2023 20:30
This was referenced Sep 1, 2023
Closed
Closed
@legobeat
legobeatforce-pushed the devdeps-eslint branch 2 times, most recently from bc32f64 to c109492CompareSeptember 1, 2023 21:38
dependabotBotand others added 6 commits October 3, 2023 15:13
@dependabot@legobeat
Bump @metamask/eslint-config-nodejs from 11.1.0 to 12.1.0
955640c
Bumps [@metamask/eslint-config-nodejs](https://github.com/MetaMask/eslint-config) from 11.1.0 to 12.1.0.
- [Release notes](https://github.com/MetaMask/eslint-config/releases)
- [Commits](MetaMask/eslint-config@v11.1.0...v12.1.0)
---
updated-dependencies:
- dependency-name: "@metamask/eslint-config-nodejs"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot@legobeat
Bump @metamask/eslint-config-typescript from 11.1.0 to 12.1.0
c1f185f
Bumps [@metamask/eslint-config-typescript](https://github.com/MetaMask/eslint-config) from 11.1.0 to 12.1.0.
- [Release notes](https://github.com/MetaMask/eslint-config/releases)
- [Commits](MetaMask/eslint-config@v11.1.0...v12.1.0)
---
updated-dependencies:
- dependency-name: "@metamask/eslint-config-typescript"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@legobeat
devDeps: resolve peerDependencies
60359fd
@legobeat
lint: disable @typescript-eslint/consistent-type-imports
f411084
@legobeat
fixup
e6c4f34
@legobeat
eslint-disable
dc953df
Mrtenz
Mrtenz reviewed Oct 3, 2023
View reviewed changes
Comment thread.eslintrc.js
files: ['*.ts'],
extends: ['@metamask/eslint-config-typescript'],
rules: {
'@typescript-eslint/consistent-type-imports': 'off',

@MrtenzMrtenzOct 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we solve this, rather than disabling the rule?

@legobeatlegobeatOct 3, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do believe so, but I consider that separate from the package upgrade.

@legobeatlegobeatOct 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But feel free to add on a commit if you think it fits better here.

@mcmiremcmireOct 5, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I'm having second thoughts about always deferring lint violation fixes when we upgrade lint packages by disabling ESLint rules like this. The thing is that whether we make these fixes now or later, we still have to make them, and it's easy to forget about them in the swath of other maintenance tasks we need to make time for. I understand that in other packages (e.g. core), we chose to disable various ESLint rules in order to lighten the load of the resulting diff, and so the compromise we made was acceptable. But I wonder if it in smaller libraries like this it wouldn't add too much to the diff to address violations for this rule at the same time as the upgrade?

@legobeat
legobeat marked this pull request as draft October 7, 2023 02:56
@legobeatlegobeat mentioned this pull request Oct 12, 2023
Closed
3 tasks
@legobeat

legobeat commented Oct 12, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This was squashed, resubmitted and merged as duplicate #169

@legobeat
legobeat deleted the devdeps-eslint branch October 12, 2023 01:04
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@mcmiremcmiremcmire left review comments
@MrtenzMrtenzMrtenz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependenciesPull requests that update a dependency filehelp wanted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat@mcmire@Mrtenz