Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Oct 7, 2024. It is now read-only.
deps: bump @metamask/providers to v14; bump @metamask/snaps packages to latest - #209
Merged
Merged
Conversation
legobeatforce-pushed
the
deps-metamask-providers-14
branch
from
November 22, 2023 08:44
e19f455 to
5e36421CompareRemoved dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages:@metamask/providers@13.1.0, @metamask/snaps-utils@4.0.1 |
legobeatforce-pushed
the
deps-metamask-providers-14
branch
from
November 22, 2023 09:05
5e36421 to
1849adbCompare13 tasks
FrederikBolding pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Nov 22, 2023
## **Description** - deps: @metamask/providers@^13.1.0->^14.0.2 - deps: extension-port-stream@^2.1.1->^3.0.0 - deps: json-rpc-middleware-stream@^4.2.1->^5.0.1 This fully removes runtime dependency on `@metamask/providers@13.x`, except for `@metamask/keyring-api` (MetaMask/keyring-api#209) ## **Related issues** ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
danroc
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metamask/providers@^13.0.0->^14.0.1@metamask/snaps-packages to latestThis is a breaking change due to the update of
@metamask/providers: https://github.com/MetaMask/providers/releases/tag/v14.0.0Consolidating updates into a single PR in order to not create duplication with incompatible versions of
extension-port-stream.Blocking