[FLASK] Remove long-running Snap permission - #20951
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
david0xd
force-pushed
the
dd/remove-endowment-long-running
branch
from
September 19, 2023 11:00
67f1d37 to
e426bb9
Compare
david0xd
force-pushed
the
dd/remove-endowment-long-running
branch
from
September 27, 2023 09:32
e426bb9 to
99fddd6
Compare
david0xd
force-pushed
the
dd/remove-endowment-long-running
branch
from
September 27, 2023 09:33
99fddd6 to
db3a1a3
Compare
david0xd
marked this pull request as ready for review
September 27, 2023 09:34
FrederikBolding
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
long-runningSnap endowment/permission.Snaps team have decided to remove this endowment because of its unpredictable security concerns around running Snaps indefinitely. This endowment is removed in favor of the new endowments that will be focused on solving certain use cases that require snap to be running for more time than default.
Related issues
Fixes #945
Related PR
MetaMask/snaps#1751 (required)
MetaMask/metamask-docs#919
Pre-merge author checklist
Pre-merge reviewer checklist