Skip to content

bump devDependencies - #44

Merged
legobeat merged 8 commits into
MetaMask:mainfrom
legobeat:devDeps-bumps-v1
Oct 25, 2023
Merged

bump devDependencies#44
legobeat merged 8 commits into
MetaMask:mainfrom
legobeat:devDeps-bumps-v1

Conversation

@legobeat

Copy link
Copy Markdown
Contributor

non-breaking maintenance updates. In particular, updates Typescript to 4.8.4.

@legobeatlegobeat added the dependencies Pull requests that update a dependency file label Sep 28, 2023
@socket-security

socket-securityBot commented Sep 28, 2023

Copy link
Copy Markdown

@socket-security

socket-securityBot commented Sep 28, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: hasown@2.0.0, defined@1.0.1, define-properties@1.2.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor
    @SocketSecurity ignore defined@1.0.1
    

    new author ok

    @legobeat
    legobeat marked this pull request as ready for review September 28, 2023 04:38
    @legobeat
    legobeat requested a review from a team as a code ownerSeptember 28, 2023 04:38
    @legobeat
    legobeat requested review from a teamOctober 2, 2023 08:50
    @legobeat
    legobeat requested a review from a teamOctober 24, 2023 00:27
    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor
    @SocketSecurity ignore hasown@2.0.0
    

    new author ok

    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor
    @SocketSecurity ignore define-properties@1.2.1
    

    unpublished (?)

    Comment threadpackage.json Outdated
    @legobeat
    legobeat requested a review from MrtenzOctober 24, 2023 09:58
    @legobeatlegobeat mentioned this pull request Oct 24, 2023
    Merged
    2 tasks
    Mrtenz
    Mrtenz previously approved these changes Oct 24, 2023
    Comment threadpackage.json
    "eslint": "^7.32.0",
    "eslint-config-prettier": "^8.3.0",
    "eslint-plugin-import": "^2.23.4",
    "eslint-plugin-import": "2.26.0",

    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We use ~2.26.0 elsewhere.

    @legobeatlegobeatOct 25, 2023

    Copy link
    Copy Markdown
    ContributorAuthor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Can loosen this when rest of eslint packages are bumped

    @legobeat
    legobeat merged commit 210d605 into MetaMask:mainOct 25, 2023
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    dependenciesPull requests that update a dependency file

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @legobeat@Mrtenz