Uh oh!
There was an error while loading. Please reload this page.
fix: publish readable-stream types dependency - #64
Open
Serjik-Developer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
@types/readable-streamfromdevDependenciestodependencies.The package emits TypeScript declarations that import and augment
readable-stream. Consumers compiling those declarations need the type package installed transitively.Verification
npx tsc --project .Note
Low Risk
Packaging-only change with no application or runtime logic modified; slightly increases install footprint for all consumers.
Overview
Moves
@types/readable-streamfromdevDependenciestodependenciesso it is installed for consumers of the published package.Published
.d.tsoutput (including module augmentation inreadable-stream.d.ts) referencesreadable-streamtypes; without this package as a transitive dependency, TypeScript projects that depend on@metamask/object-multiplexcan fail to resolve those types at compile time.Reviewed by Cursor Bugbot for commit f855b7a. Bugbot is set up for automated code reviews on this repo. Configure here.