Skip to content

fix: publish readable-stream types dependency - #64

Open
Serjik-Developer wants to merge 1 commit into
MetaMask:mainfrom
Serjik-Developer:codex/fix-types-dependency
Open

fix: publish readable-stream types dependency#64
Serjik-Developer wants to merge 1 commit into
MetaMask:mainfrom
Serjik-Developer:codex/fix-types-dependency

Conversation

@Serjik-Developer

@Serjik-DeveloperSerjik-Developer commented Aug 6, 2026

Copy link
Copy Markdown

Summary

Move @types/readable-stream from devDependencies to dependencies.

The package emits TypeScript declarations that import and augment readable-stream. Consumers compiling those declarations need the type package installed transitively.

Verification

  • npx tsc --project .

Note

Low Risk
Packaging-only change with no application or runtime logic modified; slightly increases install footprint for all consumers.

Overview
Moves @types/readable-stream from devDependencies to dependencies so it is installed for consumers of the published package.

Published .d.ts output (including module augmentation in readable-stream.d.ts) references readable-stream types; without this package as a transitive dependency, TypeScript projects that depend on @metamask/object-multiplex can fail to resolve those types at compile time.

Reviewed by Cursor Bugbot for commit f855b7a. Bugbot is set up for automated code reviews on this repo. Configure here.

@Serjik-Developer
Serjik-Developer requested a review from a team as a code ownerAugust 6, 2026 13:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Serjik-Developer