Skip to content

feat: Allow overriding default Stream options - #110

Merged
legobeat merged 4 commits into
MetaMask:mainfrom
legobeat:stream-options
May 15, 2024
Merged

feat: Allow overriding default Stream options#110
legobeat merged 4 commits into
MetaMask:mainfrom
legobeat:stream-options

Conversation

@legobeat

@legobeatlegobeat commented May 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • feat: Allow overriding stream constructor options in storeTransformStream
  • feat: Allow overriding stream constructor options in ObservableStoreStream constructor
  • feat: Allow overriding stream constructor options in storeAsStream function
  • chore: add @types/readable-stream
    • See commit message for details and object-multiplex for another package in a similar situation already using the same approach
  • chore: update @types/node from v10 to v14

@legobeat
legobeat requested a review from a team as a code ownerMay 15, 2024 03:00
@socket-security

socket-securityBot commented May 15, 2024•
edited
Loading

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@types/node@14.18.63None01.61 MBtypes
npm/@types/readable-stream@4.0.0None+156.6 kBtypes
npm/undici-types@5.26.5None073.1 kBethan_arrowood

🚮 Removed packages:npm/@types/node@10.17.42

View full report↗︎

@legobeat
legobeat requested a review from a teamMay 15, 2024 03:00
@legobeatlegobeat changed the title fest: Allow overriding default Stream optionsfeat: Allow overriding default Stream optionsMay 15, 2024
@legobeat
chore(devDeps): add @types/readable-stream
ec1db7c
- @types/readable-stream v3 does not exist
- @types/readable-stream 4.0.0 maps to v3 except missing function
- @types/readable-stream >4.0.0 not compatible with readable-stream v3
@legobeat
fix: update @types/node from v10 to v14
42f53fd
@legobeat
feat: allow overriding stream constructor options in storeTransformSt…
4b0dcd7
…ream
@legobeat
feat: allow overriding stream constructor options for ObservableStore…
d3e5052
…Stream
This was referenced May 15, 2024
Draft
Merged
rekmarks
rekmarks approved these changes May 15, 2024
View reviewed changes

@rekmarksrekmarks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@legobeat
legobeat merged commit 5d43cde into MetaMask:mainMay 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rekmarksrekmarksrekmarks approved these changes
@kumaviskumavisAwaiting requested review from kumavis
@mcmiremcmireAwaiting requested review from mcmire
@GudahttGudahttAwaiting requested review from Gudahtt
@naugturnaugturAwaiting requested review from naugtur
@weizmanweizmanAwaiting requested review from weizman

Assignees

No one assigned

Labels

None yet

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat@rekmarks