Skip to content

chore: Convert to monorepo - #2

Merged
rekmarks merged 15 commits into
mainfrom
monorepo-setup
Jul 12, 2024
Merged

chore: Convert to monorepo#2
rekmarks merged 15 commits into
mainfrom
monorepo-setup

Conversation

@rekmarks

@rekmarksrekmarks commented Jul 9, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Converts this repository to a monorepo per the conventions of https://github.com/MetaMask/core, with some inspiration from https://github.com/MetaMask/snaps where applicable. Also replaces tsup with ts-bridge per MetaMask/providers#336.

This includes a direct copy of MetaMask/metamask-module-template#246.

mcmireand others added 4 commits June 28, 2024 16:44
@mcmire@rekmarks
chore: Install Corepack as prereq in broken workflows
538e608
A recent commit upgraded the version of Yarn to v4 and removed the Yarn
binary from the repo, thereby requiring that Corepack be installed in
order to install dependencies. The `build-lint-test` was updated to
install Corepack, but not the documentation-related workflows, so they
are failing.
This commit fixes those workflows to install Corepack. It also cleans up
some work that was done in previous commits:
- In the `build-lint-test` workflow we ensure that `prepare` is run once
per Node version we are testing and that `build` and `lint` use the
latest Node version we are testing.
- In steps where we are installing Node just to gain access to the
`corepack` executable, we use `.nvmrc` (the version of Node we use for
development) to know which version of Node to install rather than using
the latest LTS (`lts/*`). For jobs that do not need to concern
themselves with being run in multiple Node versions, this ensures that
consistent Node versions are used in this step vs. the step that is used
to simply restore the Yarn cache.
- The checkout step always goes first, this way `.nvmrc` can be read.
@rekmarks
chore: Bump yarn to 4.2.2, add constraints
8c077c0
@rekmarks
chore: Convert to monorepo
008cedc
Set up as monorepo per the conventions of the `/core` monorepo, with
some inspiration from `/snaps` where applicable.
@rekmarks
chore: Replace tsup with ts-bridge
b4c2fe8
@socket-security

socket-securityBot commented Jul 9, 2024•
edited
Loading

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@metamask/ocap-playground@0.0.0-use.localNone00 B
npm/@types/node@18.19.39None+12.04 MBtypes
npm/@yarnpkg/types@4.0.0None+192.8 kByarnbot
npm/braces@3.0.3None+393.9 kBjonschlinkert
npm/debug@4.3.5environment042.4 kBqix
npm/deepmerge@4.3.1None031.2 kBtehshrike
npm/graceful-fs@4.2.11environment, filesystem032.5 kBisaacs
npm/jest-silent-reporter@0.6.0environment+8168 kBrickhanlonii
npm/micromatch@4.0.7None056.3 kBpaulmillr
npm/minipass@7.1.2None0286 kBisaacs
npm/ocap-kernel-monorepo@0.0.0-use.localNone00 B
npm/rimraf@6.0.0Transitive: environment, filesystem, shell+233.26 MBisaacs
npm/typedoc-plugin-missing-exports@2.3.0None012.4 kBgerrit0
npm/typedoc@0.24.8Transitive: environment, filesystem, network+1019.9 MBtypedoc-bot
npm/typescript@4.9.5None066.8 MBtypescript-bot

🚮 Removed packages:npm/@metamask/metamask-module-template@0.0.0-use.local, npm/@types/node@18.19.34, npm/@yarnpkg/types@4.0.0-rc.52, npm/braces@3.0.2, npm/debug@4.3.4, npm/graceful-fs@4.2.10, npm/minipass@7.0.4, npm/ts-node@10.7.0, npm/typedoc@0.23.15, npm/typescript@4.8.4

View full report↗︎

@socket-security

socket-securityBot commented Jul 9, 2024•
edited
Loading

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@jest/types@26.6.2, npm/@metamask/ocap-playground@0.0.0-use.local, npm/@types/node@18.19.39, npm/@types/yargs@15.0.19, npm/@yarnpkg/types@4.0.0, npm/ansi-sequence-parser@1.1.1, npm/braces@3.0.3, npm/chokidar@3.6.0, npm/ci-info@2.0.0, npm/debug@4.3.5, npm/deepmerge@4.3.1, npm/fill-range@7.1.1, npm/glob@11.0.0, npm/graceful-fs@4.2.11, npm/is-ci@2.0.0, npm/jackspeak@4.0.1, npm/jest-silent-reporter@0.6.0, npm/jest-util@26.6.2, npm/jsonc-parser@3.3.1, npm/lru-cache@11.0.0, npm/marked@4.3.0, npm/micromatch@4.0.7, npm/minimatch@10.0.1, npm/minimatch@9.0.5, npm/minipass@7.1.2, npm/ocap-kernel-monorepo@0.0.0-use.local, npm/package-json-from-dist@1.0.0, npm/path-scurry@2.0.0, npm/rimraf@6.0.0, npm/shiki@0.14.7, npm/typedoc-plugin-missing-exports@2.3.0, npm/typedoc@0.24.8, npm/typescript@4.9.5, npm/typescript@5.1.6, npm/vscode-oniguruma@1.7.0, npm/vscode-textmate@8.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

    @rekmarks

    rekmarks commented Jul 9, 2024

    Copy link
    Copy Markdown
    MemberAuthor

    @SocketSecurity ignore-all

    Mrtenz
    Mrtenz reviewed Jul 9, 2024
    View reviewed changes
    Comment threadpackages/ocap-playground/package.json Outdated
    @rekmarks
    rekmarks marked this pull request as ready for review July 10, 2024 15:27
    @rekmarks
    rekmarks requested a review from a teamJuly 10, 2024 15:27
    @rekmarks
    rekmarks changed the base branch from main to fix-workflows-for-yarn-v4July 10, 2024 15:28
    @rekmarks
    rekmarks changed the base branch from fix-workflows-for-yarn-v4 to mainJuly 10, 2024 15:28
    @rekmarksrekmarks mentioned this pull request Jul 10, 2024
    Closed
    @rekmarks
    rekmarks enabled auto-merge (squash) July 10, 2024 15:35
    @rekmarks
    rekmarks requested a review from MrtenzJuly 10, 2024 16:21
    Mrtenz
    Mrtenz reviewed Jul 11, 2024
    View reviewed changes
    Comment threadpackage.json Outdated
    Mrtenz
    Mrtenz reviewed Jul 11, 2024
    View reviewed changes
    Comment threadconstraints.pro
    @rekmarks
    rekmarks requested a review from MrtenzJuly 12, 2024 09:34
    @rekmarks
    rekmarks merged commit c9cb406 into mainJul 12, 2024
    @rekmarks
    rekmarks deleted the monorepo-setup branch July 12, 2024 09:38
    @rekmarksrekmarks mentioned this pull request Jul 15, 2024
    Merged
    rekmarks added a commit that referenced this pull request Jul 15, 2024
    @rekmarks
    chore: Delete cruft (#4)
    19b37d4
    Deletes left over cruft missed in #2.
    FUDCo added a commit that referenced this pull request Mar 14, 2025
    @FUDCo
    chore: @#$#@$ coverage#2
    7d0be7d
    @sirtimidsirtimid mentioned this pull request Nov 4, 2025
    Closed
    8 tasks
    This was referenced Jan 7, 2026
    Merged
    Merged
    Closed
    @grypezgrypez mentioned this pull request Jul 15, 2026
    Closed
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @MrtenzMrtenzMrtenz approved these changes

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @rekmarks@Mrtenz@mcmire