Skip to content

build(shims): Bundle eventual-send using @endo/bundle-source - #22

Merged
SMotaal merged 2 commits into
mainfrom
smotaal/eventual-send-shim-via-bundle-source
Aug 15, 2024
Merged

build(shims): Bundle eventual-send using @endo/bundle-source#22
SMotaal merged 2 commits into
mainfrom
smotaal/eventual-send-shim-via-bundle-source

Conversation

@SMotaal

@SMotaalSMotaal commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Resolves:

This use @endo/bundle-source to bundle eventual-send in @ocap/shims from its node_modules source instead of the pre-bundled src/eventual-send.mjs that was introduced in #8 for expediency.

Possible concerns:

Other notable changes:

  • Bumps related @endo/* dependencies for @ocap/extension and `@ocap/shims.
  • Drops mkdirp from the devDependencies of @ocap/shims in favour of using mkdir(<path>, { recursive: true }) directly in Node.js.

@socket-security

socket-securityBot commented Aug 15, 2024

Copy link
Copy Markdown

@socket-security

socket-securityBot commented Aug 15, 2024

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/glob@7.2.3, npm/inflight@1.0.6, npm/source-map@0.5.7

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

    @SMotaal

    Copy link
    Copy Markdown
    ContributorAuthor

    @SocketSecurity ignore npm/glob@7.2.3 npm/inflight@1.0.6 npm/source-map@0.5.7

    • Both npm/glob@7.2.3 and npm/inflight@1.0.6 already existed as nested dependencies (checked via yarn why <package>).
    • npm/source-map@0.5.7 is introduced as a nested dependency for @endo/bundle-source@3.3.0 via @agoric/babel-generator@7.17.6

    @SMotaal
    SMotaal marked this pull request as ready for review August 15, 2024 19:43
    @SMotaal
    SMotaal requested a review from a team as a code ownerAugust 15, 2024 19:43

    @rekmarksrekmarks left a comment

    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @SMotaal
    SMotaal merged commit 443cdcb into mainAug 15, 2024
    @SMotaal
    SMotaal deleted the smotaal/eventual-send-shim-via-bundle-source branch August 15, 2024 20:43
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @SMotaal@rekmarks