Skip to content

chore: Bump TypeScript and ESLint to latest versions - #27

Merged
rekmarks merged 3 commits into
mainfrom
rekm/bump-typescript
Aug 19, 2024
Merged

chore: Bump TypeScript and ESLint to latest versions#27
rekmarks merged 3 commits into
mainfrom
rekm/bump-typescript

Conversation

@rekmarks

@rekmarksrekmarks commented Aug 19, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Closes#24

Bumps TypeScript, ESLint, and @metamask/eslint-config-* to the latest available versions. Makes necessary fixes to please our updated linter.

@socket-security

This comment was marked as resolved.

Sign in to view
Base automatically changed from rekm/lockfile-reset to mainAugust 19, 2024 14:23
@rekmarks
rekmarks marked this pull request as ready for review August 19, 2024 14:35
@rekmarks
rekmarks requested a review from a team as a code ownerAugust 19, 2024 14:35
@rekmarks
rekmarksforce-pushed the rekm/bump-typescript branch from 6440771 to 388e0a1CompareAugust 19, 2024 14:36
SMotaal
SMotaal approved these changes Aug 19, 2024
View reviewed changes

@SMotaalSMotaal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the following note:

I went over the changed files in glimpses as the checks are passing. My thinking is any possible concerns may only show up and be addressed separately down the road.

If that is okay with you, please do land, or otherwise, please re-request my review.

@rekmarks
rekmarks merged commit ec4bd02 into mainAug 19, 2024
@rekmarks
rekmarks deleted the rekm/bump-typescript branch August 19, 2024 16:34
SMotaal added a commit that referenced this pull request Aug 22, 2024
@SMotaal
chore: Bump TypeScript versions per#27(undoing#16)
f8e5e6c
SMotaal added a commit that referenced this pull request Aug 22, 2024
@SMotaal
chore: Re-bump TypeScript versions per#27undoing#16(#35)
2d82dee
This bumps `typescript@5.5.4` once again, reapplying changes from #23
which were accidentally reverted in #16.
This also applies minor patches to `packages/shims/scripts/bundle.js` to
prevent a known failure in `node@18`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@SMotaalSMotaalSMotaal approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump TypeScript to v5.5

2 participants

@rekmarks@SMotaal