Skip to content

test(extension): Refactor e2e test script - #270

Merged
rekmarks merged 4 commits into
grypez/cli-integrate-e2e-testsfrom
rekm/e2e-test-script
Dec 6, 2024
Merged

test(extension): Refactor e2e test script#270
rekmarks merged 4 commits into
grypez/cli-integrate-e2e-testsfrom
rekm/e2e-test-script

Conversation

@rekmarks

@rekmarksrekmarks commented Dec 6, 2024

Copy link
Copy Markdown
Member

Refactors the e2e test invocation to avoid a timed hangup of the server. We still start the server in parallel with Playwright, but we always close the server by killing its process after the tests end.

@rekmarks
rekmarks marked this pull request as ready for review December 6, 2024 18:34
@rekmarks
rekmarks requested a review from a team as a code ownerDecember 6, 2024 18:35

@grypezgrypez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@rekmarks
rekmarks merged commit 032b36d into grypez/cli-integrate-e2e-testsDec 6, 2024
@rekmarks
rekmarks deleted the rekm/e2e-test-script branch December 6, 2024 18:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rekmarks@grypez