Uh oh!
There was an error while loading. Please reload this page.
test(nodejs): unit tests - #331
Merged
Merged
Conversation
grypezforce-pushed
the
grypez/nodejs-unit-tests
branch
from
January 14, 2025 20:21
5fe311e to
8e4c53eCompare4 tasks
grypezforce-pushed
the
grypez/nodejs-pkg
branch
from
January 15, 2025 17:39
e8420d9 to
47a81e9Comparegrypezforce-pushed
the
grypez/nodejs-unit-tests
branch
from
January 16, 2025 17:44
8e4c53e to
3698f69Comparegrypezforce-pushed
the
grypez/nodejs-unit-tests
branch
from
January 21, 2025 21:26
3698f69 to
9f034bbComparegrypezforce-pushed
the
grypez/nodejs-unit-tests
branch
from
January 24, 2025 21:19
9eed395 to
73dc899Comparegrypezforce-pushed
the
grypez/nodejs-unit-tests
branch
11 times, most recently
from
January 27, 2025 18:30
06f0b90 to
ca0e73aComparegrypezforce-pushed
the
grypez/nodejs-unit-tests
branch
from
January 27, 2025 18:58
ca0e73a to
d760a69Comparegrypez
marked this pull request as ready for review
January 27, 2025 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides unit test coverage for the src files of the
@ocap/nodejspackage, with the following exceptions:@ocap/nodejs/src/kernel/sqlite-kv-store.tsis uncovered, in accordance@ocap/extension/src/kernel-integration/sqlite-kv-store.ts. The unit-testing coverage for these KVStore implementations should likely factor through a common abstraction.@ocap/nodejs/src/vat/vat-worker.tsis not unit-tested, but is expressed in the associated e2e tests.The PR also reenables the e2e tests for the
@ocap/nodejspackage and improves the e2e test coverage.