Uh oh!
There was an error while loading. Please reload this page.
feat: Bundle iframe and vat worker via kernel-browser-runtime - #531
Merged
Conversation
rekmarks
commented
Jun 3, 2025
| "dist/" | ||
| ], | ||
| "scripts": { | ||
| "build": "yarn clean && tsc --project tsconfig.build.json", |
MemberAuthor
There was a problem hiding this comment.
ts-bridge's CommonJS mode disagrees with Vite's types, so we fall back to tsc. (The main reason we use ts-bridge is to dual-publish our packages as CommonJS and ESM, which is of course not a concern for private packages.)
rekmarks
marked this pull request as ready for review
June 3, 2025 01:20
rekmarks
commented
Jun 3, 2025
Comment on lines
+29
to
+32
| const preludePath = /^import ["']([^"']+)["']/iu.exec(prelude.content)[1]; | ||
| if (!preludePath) { | ||
| throw new Error('No prelude path found in content'); | ||
| } |
MemberAuthor
There was a problem hiding this comment.
We don't actually use the prelude.content form in this package yet, but the tests Should Just WorkTM if we ever do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #461
#522 introduced the
kernel-browser-runtimepackage, which bundled the kernel Web Worker. Further experiments indicated that it would be salutary for this package to bundle the vat worker, i.e. vat iframe, as well.To facilitate this, we replace
esbuildwithviteinkernel-browser-runtime, and extract all vat iframe-related functionality to this package. We also extract the extension's Vite plugins into a dedicated, private package so that they can be reused.Finally, during development, it was discovered that Vite duplicates the
@sqlite.org/sqlite.wasmWASM binaries. This was a preexisting issue in the extension, when we bundled the kernel worker there. Thankfully, the duplicate files are extraneous and can be deleted, which is done using an inline plugin inkernel-browser-runtime.Many red herrings died in the creation of this PR.